My new open source cms
 

Hi everyone
I just finished designing a new open source cms named "DIY-CMS" that is Do It Yourself CMS. Please check it at this link. http://www.diy-cms.com or download it from here http://www.diy-cms.com/mod.php?mod=d..._file&downid=1
and give any suggestion of feedback you have on any area (except the design :-) because I am not a designer).

I know you requested no feedback on design but you do need a new one, it is terrible in my opinion and i would not use it for that reason.

Also i do not see how you can call it yours, reading your website it says you took a popular arab cms and just modified the code, so you added a few features, re-organized it but still kind of a cheap way to make it in my thoughts, I recommend start from scratch and build it yourself.

thanks for the response, and sorry for the misunderstanding. Actually, I rewrote about 85% of the whole cms. I just used number of files in that cms which I am one of its developers (and still). thanks for the response anyway

All I got when I downloaded it was a 1.86MB "mod.php" file with 15,000 lines of code in it. Over half were corrupt. There was no readme, no install script, not even the decency to compress the file.

I would recommend that you change your distribution methods and server side design.

The folder is compressed and contains a readme file and the database as well as the rest of the files. I just tried downloading it and it seemed fine to me. I will try to download it from another computer maybe there is something wrong with the download module.

try this link to see if there is something different:
http://www.diy-cms.com/mod.php?mod=d...=goto&downid=1

http://lmgtfy.com/?q=php5

Also, Objects should have specific functions this one seems to be all over the place. ( I refer to functions.class.php )

And you have an awkward naming convention like module_outPut.

The zip file was corrupt both times I tried to download it.

My Thoughts...

1. The download fails in Chrome, (It works in FF 3.6pre) it must be a header issue. Here is a list of HTTP MIME Types.
   
2. The robots.txt doesn't specify any links that the search engine can index.
   
3. You have no comments, this is bad, very bad.
   
4. Switch/Case Expressions work a lot better than if/elif/elif/elif...
   
5. if (($y>1582)||(($y==1582)&&($m>10))||(($y==1582)&&($ m==10)&&($d>14)))
   
   Wow, thats not easy to read.
   
6. It seems that every "modual" has a separate admin panel, this is not only bad but a waste of space.
   

I would not use or recommend this because it doesn't seem to have the level of effort put into that other CMS systems do. The longest comment for anything other than the readme.txt (and phpmailer) was a single line.

Commenting is required if you expect anyone to modify your code.

Thanks all for such constructive criticism.

Enfernikus: thank you for posting the download, and regards the class issue, this problem existed in the original cms. I modified, removed and moved many functions in this file, yet it still unprofessional. I will certainly change it to something more specific.


adamdecaf
I have tested the download on FF, IE7 and IE8 it seemed to be working fine, yet on chrome there are some issues. I changed the mime type in the header but ended up with the same error.

All your comments are valid, yet I have one question, you said:
How is that bad? My understanding is that modules or plug-ins come as a package, so if I want say remove the module I would not need the admin panel related to it.
Is there another approach to creating modules in a cms.

If I were to put myself in a normal users shoes I would assume that I have one control panel that manages everything in the CMS, not four or five that only manage parts of it.

A better option for the admin panel in my opinion is providing hooks for instance a provide a function that could hook onto the admin's menu and add items and have it return a resource which the same function could hook onto therefore creating a submenu. All of these hooks would in kind be linked to a page which is encapsulated by the master admin theme but the contents of which be provided by the module's admin file.

The ZIP file has HTML at the beginning and end. This is a common mistake, it means that you are writing the entire page to the HTTP output stream instead of just the file.

Enfernikus: thanks for the advice. I tried this already with module settings. However, let say the admin wants to give a moderating permission to a group or a member on a part of cms. So if the member wants to moderate the cms he will do so through the frontend and not through the admin panel.

Basically, the admin gives permissions through the admin panel by a hooked module file, yet practicing these permissions will be through the fronted so only the admin has access to the admin control panel.

Village Idiot: thanks for the great advice. The issue is now fixed and I tested downloading the file on chrome browser, and it worked just fine. One question though: why your name is the village idiot, you should be more like the php village :) just kidding