my guestbook , i need critisizes

webtuto · 02-29-2008, 11:32 PM

hey i just finish a guestbook with admin panel i need your suggestions and critics

here is the link => http://mixwebs.com/guest/home.php

and for the admin
http://mixwebs.com/guest/admin.php

name = az
pass = az

thanks im looking forward for your comments

Rendair · 02-29-2008, 11:37 PM

The only thing i can see is some spelling mistakes like when you go to the admin login it says "Please full in all details" should be fill?

webtuto · 02-29-2008, 11:39 PM

lol yea it should be filled

StevenF · 02-29-2008, 11:56 PM

Good job! I like it. It has a lot of features I'm trying to learn and incorporate into my shopping cart:

Sessions - to check if the user is already logged in - which I see you've used
Logout - I also need to check up on how to log out, probably destroy the session?

Everything else I can do but I really need to learn about sessions. Can I ask where you found out about them?

freenity · 03-01-2008, 12:13 AM

sql injection in admin login username field

Quote:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/sites/mixwebs.com/public_html/guest/login.php on line 7

webtuto · 03-01-2008, 12:21 AM

yeah thanks freenity
for steven => i use cookies not session

freenity · 03-01-2008, 12:33 AM

Quote:

Originally Posted by StevenF

Good job! I like it. It has a lot of features I'm trying to learn and incorporate into my shopping cart:

Sessions - to check if the user is already logged in - which I see you've used
Logout - I also need to check up on how to log out, probably destroy the session?

Everything else I can do but I really need to learn about sessions. Can I ask where you found out about them?

There is an article on this site about sessions, have a look TalkPHP - vbArticles

StevenF · 03-01-2008, 12:57 AM

Quote:

Originally Posted by webtuto

yeah thanks freenity
for steven => i use cookies not session

Oh ok, is there much to it?

Quote:

Originally Posted by freenity

There is an article on this site about sessions, have a look TalkPHP - vbArticles

Thank you, I'll give it a read soon.

webtuto · 03-01-2008, 12:59 AM

what do u mean steven by if there is much for cookies !!!!!!! ook at the fridge lol
i didnt undertsnad what u mean

Alan @ CIT · 03-01-2008, 01:01 AM

webtuto: Guestbook looks nice, good job

Steven: Sessions are pretty straight forward for simple uses:

PHP Code:


			
session_start();

$_SESSION['bar'] = 'foo';

$_SESSION['something'] = 4;

Just call session_start() at the top of each page and you can access all variables in $_SESSION[].

There are more options if you need them but that's the basics

Alan

ubie · 03-08-2008, 12:41 PM

well nice script ..
but i cant see link to delete the comment ..
i think it will better if you add an capthca validation before submitting data to guestbook ;)

webtuto · 03-08-2008, 01:08 PM

yeah i need captcha , im working on it
i just fnished bbcode on my local
and about deleting messages , u hav to login as an admin and return to the home.php page , and there u gonna see a link to delete the message or ban the message writer , and u can see his ip also

ubie · 03-08-2008, 01:17 PM

well i will wait for ur new guestbook vertion ^__^

webtuto · 03-08-2008, 01:20 PM

yeah loOl
tell me what features you see that i have to add on the new version ??

CΛSTΞX · 03-10-2008, 12:20 AM

The design is very bad. If you give your php script to me, I will help you. I am a designer...

zxt3st · 04-17-2008, 03:59 AM

the spelling bro..:P..and maybe you could allow the use of bbcodes..:p..and smileys..

Izym · 05-24-2008, 01:01 PM

Quote:

Originally Posted by t3st

the spelling bro..:P..and maybe you could allow the use of bbcodes..:p..and smileys..

Talk for yourself - You know, ".." isn't a replacement for " ". ;)

ETbyrne · 05-24-2008, 04:33 PM

Don't bump old topics please.