TalkPHP - Password generator

TalkPHP (http://www.talkphp.com/forums.php)

- Script Giveaway (http://www.talkphp.com/script-giveaway/)

- - Password generator (http://www.talkphp.com/script-giveaway/1696-password-generator.html)

Password generator

Figured I'd give away my password generator.

PHP Code:


		
			
public function generatePassword($length = 10) {
    // Build an arrays of consonants and vowels
    $consSingle = str_split('bcdghjklmnprstuvw');
    $consDouble = str_split('trcrbrfrthdrchphwrstspswprslcl', 2);
    $cons       = array_merge($consSingle, $consDouble);
    $vowels     = str_split('aeiou');
    $numbers    = array(1, 2, 3, 4, 5, 6, 7, 8, 9, 0);
    
    // Create the random password
    $password = '';
    srand((double) microtime() * 1000000);
    for ($i = 0; $i < $length; $i++) {
        // Alternate between upper and lower case
        $casing = (rand(0, 1))? 'strtoupper' : 'strtolower';
        
        // Construct the password by a series of constanent + number + vowel.
        $password .= (
            $casing($cons[ mt_rand(0, 31) ])
            . $numbers[ mt_rand(0, 9) ]
            . $casing($vowels[ mt_rand(0, 4) ])
        );
    }
    
    // Cut string and return password to correct length
    return substr($password, 0, $length);
}

Usage:

PHP Code:


		
			
$pass = generatePassword();
$enc = md5('pew! pew! pew!' . $pass);

Wouldn't it be easier just to output random characters? That way you could choose length and mix caps. MD5 outputs 35 chars, thats longer then most people have for passwords.

Avoid using str_split when you don't have to.. initializing the array yourself is a lot more efficient. str_split, and other methods that take care of initiliazing, were made for the manipulation of un-controllable data and such.

And as VI already said.. Just do random letters! Use uniqid() and MD5

PHP Code:


		
			
$pass = substr( md5( uniqid( mt_rand(), true ) ), 0, mt_rand( 5, 12 ) );

Can I just say that MD5 actually outputs string of 32 characters, not 35.

Quote:

Originally Posted by Wildhoney (Post 6195)

Can I just say that MD5 actually outputs string of 32 characters, not 35.

I should really consider learning how to count one of these days...

You could just use md5() on time() and then randomly pick a 10-char sequence from the resulting hash.. though, I'm not sure how easily that could result in duplicates (HIGHLY unlikely, though).

You can use a lot of things..

PHP Code:


		
			
$pass = substr( md5( mt_rand() ), 0, mt_rand( 6, 12 ) );
$pass = substr( uniqid( mt_rand(), true ), 0, mt_rand( 6, 12 ) );
// it goes on and on xD