Query Confusion

CMellor · 10-01-2007, 09:37 PM

Hey,

I'm pretty sure this can be classed more as a MySQL problem than a PHP one.

Check out this bit of code:

PHP Code:


			
<?php

// If submit was pressed, send PM

if(isset($_POST['submit_send_pm'])) {

    // Put in variables

    extract($_POST);

        

    // Get the recipitent's ID

    $recepID = mysql_query("SELECT id, pm_notify FROM members, settings

    WHERE username = '".$to."'

         AND pm_notify = '0'||'1'

    ");

    // Grab ID

    $recepRow = mysql_fetch_object($recepID);

        

    // Insert new info into database

    $query = mysql_query(sprintf("INSERT INTO private_msg SET

     subject = '%s',

      message = '%s',

      date = UNIX_TIMESTAMP(),

      sent_from = '%d',

      sent_to = '%d'",

        // Values

        escape($subject),

        $message,

        escape($_COOKIE['userID']),

        escape($recepRow->id)

    )) or die(mysql_error());

        

    // Check if users wants to be notified, if so, send them an e-mail

    if($recepRow->pm_notify == 1) {

        echo('Mail Sent');

    }

}

?>

Once the query has does it's work, I want to check if the user who it was sent to, has their 'pm_notify' selection set to 'yes' (or in the database, '1') If the option is set to '1', it will send an e-mail, though I just echo'd some text for testing purposes.

I can't seem to grab the 'pm_notify' row from the user to check if it is set to 0 or 1, can anyone think what might be the problem with my query?

Thanks.

Salathe · 10-01-2007, 11:36 PM

At line 10, change:

PHP Code:


			
AND pm_notify = '0'||'1'

To:

PHP Code:


			
AND pm_notify = 0 OR pm_notify = 1

Presumably the pm_notify column is BOOLEAN meaning that it can only have a value of 0 or 1, in which case there's no point checking if it is set to either 0 or 1. Because of that I don't see why you need to check the pm_notify value in the WHERE clause at all.

Wildhoney · 10-07-2007, 12:56 PM

Nor do I. Seems absurd because omitting the WHERE clause will return exactly the same as having the WHERE clause.