CodeIgniter Query Bindings

Hightower · 08-20-2009, 02:18 PM

Ok, so I should maybe post this on CI forums, but I like this place too much.

I have the following in my CI script:

PHP Code:


			
$sql = "SELECT articles.body, articles.user_id, users.username FROM articles, users WHERE ? = 1 AND articles.user_id = users.user_id ORDER BY ?";



$query = $this->db->query($sql, array('item1', 'item2'));

echo $sql;

The output from the echo however is:

Code:

SELECT articles.body, articles.user_id, users.username FROM articles, users WHERE ? = 1 AND articles.user_id = users.user_id ORDER BY ?

It's not replacing the question marks. I've checked the code, and it looks ok.

Anybody got any ideas?

Salathe · 08-20-2009, 02:47 PM

Why would you expect the value in $sql to change? It has been many years since I even touched CI code but the replacements should be done internally. Does $query contain what you expect it to contain?

Hightower · 08-20-2009, 02:53 PM

Query Bindings:

http://codeigniter.com/user_guide/database/queries.html

Bottom of this page

ioan1k · 08-20-2009, 03:14 PM

The ? will be replaced once the query is executed automatically, it also may be that CodeIgnitor does not bind field names only values even though the same has been provided, as the documentation shows values being replaced.

sketchMedia · 08-20-2009, 04:02 PM

does the $this->db->query method take in the sql variable by reference? I'm guessing not.
I don't know, never used CI.

Hightower · 08-21-2009, 07:45 AM

Quote:

Originally Posted by sketchMedia

does the $this->db->query method take in the sql variable by reference? I'm guessing not.
I don't know, never used CI.

I'm not exactly sure - all I know is my code is the exact syntax as their example.

sketchMedia · 08-21-2009, 10:37 AM

It doesn't pass byRef just looked through the source, do you understand what I'm getting at?

Take this example:

PHP Code:


			
$sql = "SELECT username FROM users WHERE password = '?'"; 

function query($sql, $repl)
{
    $sql = str_replace('?', $repl, $sql);
}

function queryref(&$sql, $repl)
{
    $sql = str_replace('?', $repl, $sql);
}


query($sql, 'cheese');
echo $sql . '<br />'. '<br />'. '<br />';


queryref($sql, 'cheese');
echo $sql;

Results:

Code:

SELECT username FROM users WHERE password = '?'


SELECT username FROM users WHERE password = 'cheese'

Basically the $sql variable in your example is in a different namespace to $this->db->query's $sql variable (as method/function params are passed byVal by default) therefore when you echo $sql; out it will still equal the value you set.

To replicate the behaviour you want/need, you could do a call-time-pass-by-reference call:

PHP Code:


			
$sql = "SELECT articles.body, articles.user_id, users.username FROM articles, users WHERE ? = 1 AND articles.user_id = users.user_id ORDER BY ?"; 

$query = $this->db->query(&$sql, array('item1', 'item2')); 
echo $sql;

This is apparently deprecated behavior however and may result in a warning.

Having not tested CI i can't be 100% thats why it isnt working, but im pretty sure (after a quick skim read of the code)

Hightower · 08-21-2009, 11:30 AM

Posted on CI in the end, was a complete school boy error.

Was echoing $sql which doesn't change. Just needed to echo $this->db->last_query() which worked spot on.

Thanks for all the assistance

dashixiong · 10-18-2012, 01:13 PM

Some conservatives have Coach Factory Outlet pushed that critique further, saying that Mr. Obama’s policies are too costly, often assist the wrong people Louis Vuitton Belts and could have the paradoxical effect of driving up college costs. The dispute turns not just on different Coach Factory Outlet assessments of how policies play out, but on differing philosophical views about the role of government. During Gucci Belts his time in office, Mr. Obama has sharply increased aid to low- and middle-income students, notably through the Pell Grant Coach Factory Outlet program, which grew from $14.6 billion given to 6 million students in 2008, to nearly $40 billion for Coach Factory Outlet almost 10 million students this year. His administration also made it easier to request aid, shortening the Coach Factory Online complex federal application and allowing people to transfer their financial information electronically from the Internal Coach Outlet Online Revenue Service database. But while many education experts laud his efforts, analysts of varying political Coach Outlet Online stripes have also questioned how much impact some of the president’s policies will have, noting that the prices Coach Online Outlet charged by colleges, and student borrowing, continue to climb.But behind the headlines about soaring costs, the Coach Factory Outlet Online reality is more complex and wildly uneven, because a growing number of students receive Coach Outlet Online financial aid, and only relatively high-income families pay those fast-rising sticker prices. Adjusted for Coach Factory Online inflation, the College Board calculates, the average net price changed little over the last decade at private Coach Factory Outlet schools, and rose only modestly at public ones.Defending federal spending, Arne Duncan, the secretary of Hermes Belts education, said that for more than 30 years, college prices had risen even when federal aid had not, leading him to believe Coach Factory Online there was zero correlation.

dashixiong · 10-22-2012, 09:17 AM

You’ve relativelyCoach Outlet recently arrived in New Delhi after living in two of Asia’s other great cities,Coach Outlet Store Online Tokyo and Hong Kong, for several years. Do these cities feel like they’re part of the same continent? Yes, and no. In terms Coach Factory Onlineof infrastructure, they couldn’t be more different. Getting regularCoach Outlet power and water at my house in New Delhi is never a sure thing, even though Coach Purse Outlet OnlineI’m paying the same rent that I paid in Tokyo and almost the same electricity prices. Both Hong Kong and Tokyo are also crowded places,Coach Factory Outlet Online but both cities are incredibly well planned and efficiently run. Efficient is not a word I would use to describe my Coach Bags Outlet Onlineday-to-day life in New Delhi. On the other hand, one thing that I think Hong Kong and New Delhi have in common isCoach Handbags Outlet a shared sense of optimism — a feeling that the best is yet to come. That’s definitely not the feeling you get in Tokyo,Coach Outlet Online or in the U.S. when I go home. It’s a big part of what I find addictive about living and working in this part of the world. You feel like you’re watching the future unfold.