My Engine/Framework

TerrorRonin · 03-27-2008, 11:04 PM

So i'm in the process of building my own engine. Hoping some of you would be willing to take some time to look over it, and give me some suggestions, etc..

PHP Source Code Reader

Above is a link to a source code viewer, it doesn't have highlight, so it's a little tedious to read, but i'll hopefully be adding highlight to it soon :)

Nor · 03-28-2008, 01:48 AM

Dude thats nice :) Looking good.

Note: robot.txt shouldn't contain XML lol
Note2: error in the # at top of page

Quote:

I also think this is the wrong forum?

TerrorRonin · 03-28-2008, 02:30 AM

Weird, didn't know there was XML in the robots :P Thanks for the heads up.

And what do you mean by your error #2?

Nor · 03-28-2008, 03:08 AM

your html isn't valid. check your source.

Orc · 03-28-2008, 06:40 AM

I got an error

PHP Code:


			
Warning: file(source/index.php) [function.file]: failed to open stream: No such file or directory in /home/clanproj/public_html/reader/index.php on line 91

Warning: Invalid argument supplied for foreach() in /home/clanproj/public_html/reader/index.php on line 94

It's obviously not a valid array for the foreach(); and the file doesnt exist, why would you need it anyway? Its just to found how many lines there are on a file, you sohuld use stat.

TerrorRonin · 03-28-2008, 09:00 AM

Sorry it was down for a bit, it's fixed now.

@Nor:
I'm not asking for critique on the reader :P I'm asking for critique on what the reader shows.

xenon · 03-28-2008, 03:16 PM

try removing the paths from the urls. it's not ok at all to pass paths like that through the system.

TerrorRonin · 03-30-2008, 10:14 AM

What do you mean xenon?

flyingbuddha · 03-31-2008, 04:56 PM

Code:

?page=..//admin/images/header-background.jpg

Ouch! I've seen system's like this before, you can just keep adding '../' after the equal sign to get to the root of your machine, then it's free roaming on your server files.

Nor · 03-31-2008, 05:15 PM

You shouldn't allow images to be parsed, more display the image it self as a image not show the compiled code :).

Nor · 03-31-2008, 05:20 PM

lol man thats very insecure!!! I actually found the sql data :O, lemme PM you the security risk bro. I pmed you maybe you'll see how that can be insecure ;)..

TlcAndres · 03-31-2008, 06:25 PM

I think it would look nicer if the code viewer and file structure were next to each other - btw you have an error on line 47 of your install file.

TerrorRonin · 03-31-2008, 08:46 PM

Thanks for the heads up on the security.

I've taken the source reader down for the time being.