phpBB3 Release Date Announced

wGEric · 12-10-2007, 06:15 AM

http://www.phpbb.com/community/viewt...?f=14&t=611789

Finally. It's taken a very long time. Has anyone tried the RCs? Does anyone plan on trying the gold release?

Haris · 12-10-2007, 07:58 AM

Wohoo, 3 more days.

I'll be sure to try it out.

d4v1d · 12-10-2007, 08:04 AM

I'm using RC7 at the mo... It's about time they announced the official release. Must say, since I updated to PHPBB3, I haven't had a single problem, one of which was spam - used to hit hard on PHPBB2...

Jay · 12-10-2007, 08:26 AM

Thanks for the info! I've been waiting for the release

wGEric · 12-12-2007, 07:14 AM

If you don't know what features phpBB3 has over phpBB2 then here is a page comparing the two: http://www.phpbb.com/about/features/

xenon · 12-12-2007, 07:32 AM

Finally! I think I'll give it a try...I tell you, version 2 did not satisfy me at all (IPB 1.3 - 2001 was waaaay better at both performance/usability/coding style than even phpBB2 last version from 2006).

Perhaps this version will bring some joy into the programmers eyes (though I'd rather buy IPB if it were for myself...I just love that piece of software). Too bad they're still using that crappy combination of object oriented with procedural style programming...but *hopefully* now will be easier to delve into.

Tanax · 12-12-2007, 08:24 AM

Is it just me, or is their site down? :S

I can't seem to get on it :(

For a free software, phpBB is definitly taken the lead!
I might go with phpBB for a started ;)

sketchMedia · 12-12-2007, 08:30 PM

i tried the beta ages ago, all i can say about it was that it was still PHPBB (in my opinion a complete mess, but thats probably because its not written in my coding style)

Geert · 12-12-2007, 08:38 PM

Quote:

Originally Posted by sketchMedia

i tried the beta ages ago, all i can say about it was that it was still PHPBB (in my opinion a complete mess, but thats probably because its not written in my coding style)

I haven't really had a look under the hood. However, I can imagine what it may look like since the amount of features and 'stuff' is incredible. Haven't even really got my head completely around permissions on the front-end, let alone the code.

It's a very powerful board of course, but maybe it wants to do too much for most users. Anyway, what am I rumbling about. Respect to the phpBB developers for creating great PHP software.

Village Idiot · 12-12-2007, 08:52 PM

PHPBB's coding is crap. Unless they went grounds up redoing it, things wont be better.

wGEric · 12-13-2007, 03:50 AM

Quote:

Originally Posted by Village Idiot

PHPBB's coding is crap. Unless they went grounds up redoing it, things wont be better.

phpBB3 is a rewrite of phpBB2. None of the code is the same.

Village Idiot · 12-13-2007, 03:53 AM

Oh, didn't know that.

xenon · 12-13-2007, 08:59 AM

Quote:

Originally Posted by wGEric

phpBB3 is a rewrite of phpBB2. None of the code is the same.

..but still, has the same crappy coding style (functions over classes, then some 'random code', then some more functions, and then a class or two), followed by some more spaghetti code. Check this out: (extras from /search.php):

Code:

// Start session management
$user->session_begin();
$auth->acl($user->data);
$user->setup('search');

// Define initial vars
$mode            = request_var('mode', '');
$search_id        = request_var('search_id', '');
$start            = max(request_var('start', 0), 0);
$post_id        = request_var('p', 0);
$topic_id        = request_var('t', 0);
$view            = request_var('view', '');

[...]

gen_sort_selects($limit_days, $sort_by_text, $sort_days, $sort_key, $sort_dir, $s_limit_days, $s_sort_key, $s_sort_dir, $u_sort_param);

if ($keywords || $author || $author_id || $search_id || $submit)
{
    // clear arrays
    $id_ary = array();

    // egosearch is an author search
    if ($search_id == 'egosearch')
    {
        $author_id = $user->data['user_id'];
        
        if ($user->data['user_id'] == ANONYMOUS)
        {
            login_box('', $user->lang['LOGIN_EXPLAIN_EGOSEARCH']);
        }
    } // and the crap goes on...

For the sake of the other programmers, choose a GOOD style and stick to it.

ReSpawN · 12-13-2007, 09:35 AM

Quote:

Originally Posted by Village Idiot

Oh, didn't know that.

I smell a burn hehe.

No just kiddin. Anyways, very nice spot man! Thanks.

ReSpawN · 12-13-2007, 03:32 PM

They've implemented a nice countdown

Can't wait till I can try it out!

wGEric · 12-13-2007, 06:17 PM

Quote:

Originally Posted by xenon

For the sake of the other programmers, choose a GOOD style and stick to it.

They did. It's their own style.

Also there have been many arguments over whether OOP and procedural is better. IMO both have their uses and both should be used in a program. It's their style not yours so you don't need to flame them for it.

I really don't see what is so "crappy" about the code you posted.

Anyways, gold has been released :)

xenon · 12-13-2007, 10:35 PM

I mentioned, and highlighted good in "good style". What's wrong with that code? Hmm let's see...

Code:

gen_sort_selects($limit_days, $sort_by_text, $sort_days, $sort_key, $sort_dir, $s_limit_days, $s_sort_key, $s_sort_dir, $u_sort_param);

Skipping that function which takes an enormously large number of parameters (instead of using some setters in a class for example), we reach this nifty init:

Code:

// clear arrays
$id_ary = array();

The comment is so useful here, that it might aswell be omitted. $id_ary is never used up to that point, so there's nothing to clear but the mind of the developer who wrote that. You might want to search other files, perhaps it's defined somewhere else, but it's not.

Up to this point, you might have reached about 20 trigger_error statements and 50+ nested if's (just in the /search.php file). I'd say that's a real improvement to the code (not).

Something really captured my attention. This:

Code:

// We do some additional checks in the module to ensure it can actually be utilised
    $error = false;
    $search = new $search_type($error);

    if ($error)
    {
        trigger_error($error);
    }

    // let the search module split up the keywords
[...]

I'll let you decide what's wrong with phpBB's source code (except the fact that modifying it is a free ride in hell).

wGEric · 12-13-2007, 11:34 PM

Quote:

Originally Posted by xenon

I mentioned, and highlighted good in "good style". What's wrong with that code? Hmm let's see...

Code:

gen_sort_selects($limit_days, $sort_by_text, $sort_days, $sort_key, $sort_dir, $s_limit_days, $s_sort_key, $s_sort_dir, $u_sort_param);

Skipping that function which takes an enormously large number of parameters (instead of using some setters in a class for example), we reach this nifty init:

You're still going to have a large list of parameters unless you make global variables or some other method. Each of those parameters can be changed while searching so you can't hard code them. Minimum requirement is PHP 4.3.3 so they can't use special PHP 5 functions.

Quote:

Code:

// clear arrays
$id_ary = array();

The comment is so useful here, that it might aswell be omitted. $id_ary is never used up to that point, so there's nothing to clear but the mind of the developer who wrote that. You might want to search other files, perhaps it's defined somewhere else, but it's not.

Up to this point, you might have reached about 20 trigger_error statements and 50+ nested if's (just in the /search.php file). I'd say that's a real improvement to the code (not).

register_globals? Always set your variables before using them so that nothing unexpected can get injected. Especially into your arrays. So if someone attempted to inject something within the array it would get cleared.

Quote:

Something really captured my attention. This:

Code:

// We do some additional checks in the module to ensure it can actually be utilised
    $error = false;
    $search = new $search_type($error);

    if ($error)
    {
        trigger_error($error);
    }

    // let the search module split up the keywords
[...]

I'll let you decide what's wrong with phpBB's source code (except the fact that modifying it is a free ride in hell).

Let me highlight this line for you:

Code:

    $search = new $search_type($error);

$error is used when creating the object for the search. It is being passed by reference so this works perfectly fine. Yes it is confusing to look at at first but there's nothing wrong with it.

I think you should understand what the code is doing before you comment on it.

Orc · 12-22-2007, 06:06 PM

It just released just a few days ago but umm Olympus is the Edition of the Name! Or version 3.0.0 as to be called :D