TalkPHP - Can't make it to sort...

TalkPHP (http://www.talkphp.com/forums.php)

- Advanced PHP Programming (http://www.talkphp.com/advanced-php-programming/)

- - Can't make it to sort... (http://www.talkphp.com/advanced-php-programming/4512-cant-make-sort.html)

Can't make it to sort...

Good day to you all,
here i'm working on a function that read a directory, for each folder show its images.

Here's the part that don't work :
No error but don't sort while it list files it should also sort them , Portrait, Landscape, Panoramic.

Here is my code :

PHP Code:


		
			



<?php

        
         set_time_limit(0);
        

        
        $directory = $_GET['dir'];

// Function that read a directory list of folder and result them
function getDirectory( $path = '.', $level = 0 ){

    $ignore = array( 'cgi-bin', '.', '..' );
    // Directories to ignore when listing output. Many hosts
    // will deny PHP access to the cgi-bin.

    $dh = @opendir( $path );
    // Open the directory to the handle $dh
    
    while( false !== ( $file = readdir( $dh ) ) ){
    // Loop through the directory
    
        if( !in_array( $file, $ignore ) ){
        // Check that this file is not to be ignored
            
            $spaces = str_repeat( '&nbsp;', ( $level * 4 ) );
            // Just to add spacing to the list, to better
            // show the directory tree.
            
            if( is_dir( "$path/$file" ) ){
            // Its a directory, so we need to keep reading down...
            

//Creating var for Portrait images list    
    $portrait = "";
//Creating var for Landscape images list    
$landscape = "";
//Creating var for panoramic images list    
$panoramic = "";
//Read that directory
$files = scandir($path."/".$file);
// Echo the name
echo "<div id=\"bar\"><b>".$file."</b></div><br/>";
echo "<div>";

//For each file in tha folder
foreach($files as $key => $value){
    
    if ($value != "." && $value != "..") {
        
        //Substring to $value his last 5 char
        $formatfind =  substr($value,-5);
        // Subtracting to this the last 4
        $format =  substr($formatfind,0,-4);
        //This is in my naming convension.Portrait equal 1    landscape equal 0 and panoramic equal 2
        
    // if file $format equal 1
    if ($format = "1") {
// add it to portrait list
    $portrait .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$path."".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $portrait .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $portrait .= "<img src=\"".$path."".$file."/".$value."\" /><br />".$value."<br/></div>";
    }
    
// if  file $format equal 0    
    if ($format = "0") {
    $landscape .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $landscape .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $landscape .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
    
    // if  file $format equal 2    
    if ($format = "2") {
    $panoramic .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $panoramic .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $panoramic .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
  // Else, do nothing
    }else{
        
        
        }
    
}
// echo result of the 3 format
echo $portrait;
echo "<br/>";
echo $landscape;
echo "<br/>";
echo $panoramic;

echo "</div>";
echo "<br/>";
                
                
          
            }
        
        }
    
    }
    // close diretory
    closedir( $dh );
    // Close the directory handle

} 
        
        // calling the function
         getDirectory( $directory );
        
        
 ?>

Thanks !

What do you mean by "it should also sort them"? And have you tried the code I posted in your first thread?

If I'm understanding the problem correctly, I think the issue is in this section of code:

PHP Code:


		
			
    // if file $format equal 1
    if ($format = "1") {
// add it to portrait list
    $portrait .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$path."".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $portrait .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $portrait .= "<img src=\"".$path."".$file."/".$value."\" /><br />".$value."<br/></div>";
    }
    
// if  file $format equal 0    
    if ($format = "0") {
    $landscape .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $landscape .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $landscape .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
    
    // if  file $format equal 2    
    if ($format = "2") {
    $panoramic .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $panoramic .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $panoramic .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
  // Else, do nothing
    }else{
        
        
        }

An assignment operator (=) is being used instead of a comparison (==), so the 1, 2 and 3 are being assigned to $format. There is no error returned because this is still valid, and it will return true.

Below is how it probably should look:

PHP Code:


		
			
    // if file $format equal 1
    if ($format == "1") {
// add it to portrait list
    $portrait .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$path."".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $portrait .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $portrait .= "<img src=\"".$path."".$file."/".$value."\" /><br />".$value."<br/></div>";
    }
    
// if  file $format equal 0    
    if ($format == "0") {
    $landscape .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $landscape .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $landscape .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
    
    // if  file $format equal 2    
    if ($format == "2") {
    $panoramic .= "<a onmouseover=this.style.cursor=\"pointer\" ' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'block' \" ><img src=\"".$file."/".$value."\" width=\"50px\" class=\"imag\"></a>\n"; 
    $panoramic .= "<div id='".$value."' style='display: none;  position: absolute;  text-align:left; margin: 0px -300px; margin-top:-150px;  z-index:50; border: solid black 1px; padding: 10px; background-color: #ffffff; text-align: justify; font-size: 12px; onmouseover='this.style.cursor=\"pointer\" ' style='font-size: 12px;' onfocus='this.blur();' onclick=\"document.getElementById('".$value."').style.display = 'none' \" >";
    $panoramic .= "<img src=\"".$file."/".$value."\" /><br />".$value."<br/></div>";
    
    }
  // Else, do nothing
    }else{
        
        
        }