Small php error - Thank you in advance!

codefreek · 10-16-2008, 07:15 PM

there is no error outputted but i know the problem is in the preg_match part. Some assistance would be great!
Thank you!

Rules for preg:match, and to blur for me to read ;)

PHP Code:


			
int preg_match ( string $pattern , string $subject [, array &$matches [, int $flags [, int $offset ]]] )

The script is small and might be ugly but it is only a practice run ;) so no flame :)

PHP Code:


			
<?php

error_reporting(E_ALL ^ E_NOTICE);



include "config.php";



if(isset($_POST['submit']))

{



$url=$_POST['url'];

if(strlen($url)<1) 



  

{



      print "You did not enter a URL.";



  



  }



    

  }

if (preg_match('~^http://[a-z]{2,3}\.youtube\.com/\?v=[\w-]+(?:&feature=related)?$~i','',$url)) {

 

    $url="INSERT into upload (link) values('$url')";



    mysql_query($url) or die(mysql_error());



    print "Link added!";



}



else



  {



    print "<form action='index.php' method='post'>";



    print "URL(include http://):<br>";



    print "<input type='text' name='url' size='20'><br>";



    print "<input type='submit' name='submit' value='submit'></form>";



 }











?>

Code;Freeek,.

Tanax · 10-16-2008, 07:46 PM

PHP Code:


			
preg_match('~^http://[a-z]{2,3}\.youtube\.com/\?v=[\w-]+(?:&feature=related)?$~i','',$url)

supposed to be:

PHP Code:


			
preg_match('~^http://[a-z]{2,3}\.youtube\.com/\?v=[\w-]+(?:&feature=related)?$~i', $url)

I'm not sure if you have to use matches, since you just want 1 match; true or false.

codefreek · 10-16-2008, 08:01 PM

still the same..

codefreek · 10-16-2008, 08:41 PM

CODE EDIT:

PHP Code:


			
<?php

error_reporting(E_ALL ^ E_NOTICE);



include "config.php";



if(isset($_POST['submit']))

{





$url=$_POST['url'];

if(strlen($url)<1) 



  

{



      print "You did not enter a URL.";



  



  }



   else

   

   {

  

$check = (preg_match('~^http://[a-z]{2,3}\.youtube\.com/\?v=[\w-]+(?:&feature=related)?$~i','',$url));

if($check = TRUE)

{

    $url="INSERT into upload (link) values('$url')";



    mysql_query($url) or die(mysql_error());



    print "Link added!";

}

}

}



else



  {



    print "<form action='index.php' method='post'>";



    print "URL(include http://):<br>";



    print "<input type='text' name='url' size='20'><br>";



    print "<input type='submit' name='submit' value='submit'></form>";



 }











?>

tony · 10-16-2008, 09:35 PM

I tried your code and the preg_match is always returning a value, but I am guessing you just want to catch url's that come from youtube? it's a regex problem, I am not an expert in that area, but it would help to know what are you trying to match in the url.

Salathe · 10-16-2008, 09:49 PM

Your call to preg_match isn't going to work, you need to follow preg_match(pattern, test_string) for what you're trying to do with it. Also, in the if statement below it, you're assigning TRUE to the $check variable; not comparing its value to TRUE, use the double equals operator ($check == TRUE) (or ($check === 1), or simply ($check)).

codefreek · 10-16-2008, 10:12 PM

If you don't mind me asking, what do you mean by test_string ?..

PS: Thank you for the help everyone!

Tanax · 10-16-2008, 10:19 PM

The string you want to search in with the expression.

codefreek · 10-16-2008, 10:52 PM

Now when i try to submit anything i get blankpage :S?

sketchMedia · 10-16-2008, 11:11 PM

because your preg_match is returning 0 or false I guess, either that or the script is failing further up, put an else on the preg_match if statement and see if it shows, this will tell you that there might be a problem with the regex (if the string passed is known to be a valid string)

Also its pointless assigning the result of preg_match to a variable in this case as it will only result in the number of times the pattern matched and because it stops at the first match, this will be either 0 or 1 (or false if it failed in some way). As PHP uses 0 and 1 as true and false the result will only ever be true or false.

This would be a better way of doing it:

PHP Code:


			
if(preg_match('pattern','string to test'))
{
    // Do something
}
else
{
    // Do something else
}

codefreek · 10-17-2008, 12:37 AM

@sketchMedia it works now, no blank page anymore but..
it wont block out none youtube links i can write bla bla and it will accept it..
any ideas?

Thank you..

Wildhoney · 10-17-2008, 01:26 AM

You don't have an else for if the link is invalid. That would be the reason for your blank page. Try this code:

PHP Code:


			
error_reporting(E_ALL ^ E_NOTICE);
include "config.php";

if(isset($_POST['submit']))
{
    $url=$_POST['url'];
    
    if(strlen($url)<1) 
    {
        print "You did not enter a URL.";
    }
    else
    {
        if (preg_match('~^http://(?:[a-z]{2,3}\.)?youtube\.com/watch\?v=.+$~i', $url))
        {
            $url="INSERT into upload (link) values('$url')";
            mysql_query($url) or die(mysql_error());
            print "Link added!";
        }
        else
        {
            print "Link is invalid";    
        }
    }
}
else
{
    print "<form action='YouTube.php' method='post'>";
    print "URL(include http://):<br>";
    print "<input type='text' name='url' size='20'><br>";
    print "<input type='submit' name='submit' value='submit'></form>";
}

codefreek · 10-17-2008, 01:59 AM

Thank you, Wildhoney! you're the best!

PS: anyone know how i can block out so that you can not post the same link twice, maybe just do a check from db and see if that exists then print out this already in db ?
any ideas! thank you!

sketchMedia · 10-17-2008, 10:29 AM

Use 'IGNORE' on the INSERT statement.

sql Code:

INSERT IGNORE INTO `upload` (`link`) VALUES('$url')

Should stop duplicates.

codefreek · 10-17-2008, 02:33 PM

sketchMedia, it did not work.

Salathe · 10-17-2008, 03:00 PM

Quote:

Originally Posted by sketchMedia

Should stop duplicates.

Only if the link column has a unique index on it. The important thing is the index, it's up to the dev if they want to use ignore or go with the error generated when an insert tries to duplicate a unique key.

codefreek · 10-17-2008, 03:02 PM

so if i change it to a unique.. it would work?
would it also make other problems?

codefreek · 10-17-2008, 03:04 PM

PHP Code:


			
$results = mysql_fetch_array($query);

foreach($results as $result) {

if($result == $url) {

die ('SAMELINK!');

}

}

this is what tanax told me to try..

THANK YOU TANAX!

Wildhoney · 10-17-2008, 05:23 PM

Whilst that does work, just bear in mind that Salathe's approach is the more professional approach. You would make the link column an index, and set the unique property on it, you would then handle the response from MySQL.

codefreek · 10-17-2008, 05:28 PM

could anyone give an example on how to do that?
and thank you for taking time to help out
i am grateful!