Redeclaring class, but i don't ?

SpYkE112 · 06-05-2008, 06:54 PM

Well i keep getting this error:

Fatal error: Cannot redeclare class clean in /customers/pulse101.net/pulse101.net/httpd.www/dev1/backend/classes/clean.class.php on line 66

But i just can't understand it :(

Here is the file with the "error"?

PHP Code:


			
<?php
//Check if ticket
if (!defined('BACKEND_TICKET'))
{
    die();
}

//Declare the class
class clean extends p101 
{
    
    public function clean_var($var) 
    {
        //If $var = array , treat as an array
        if (is_array($var)) 
        {
            //$buffer = array();
            foreach ($var as $key => $val) 
            {
                if (is_array($var[$key])) 
                {
                    $var[$key] = $this->clean_var($val);
                } else 
                {
                    $var[$key] = $this->do_clean($val);
                }
            }
        } else 
        {
            $var = $this->do_clean($var);

        }

        return($var);
    }
    
    public function clean_globals() 
    {
        
        $array = array(
                            'POST' => $_POST,
                            'GET' => $_GET,
                            'COOKIE' => $_COOKIE,
                            'REQUEST' => $_REQUEST,
                            'SESSION' => $_SESSION,
                            'FILES' => $_FILES
                            );
                            
        foreach($array as $key => $val) 
        {
            $this->global_vars[$key] = $this->clean_var($val);
        }
    }
    
    private function do_clean($var) 
    {
        if(function_exists('get_magic_quotes_gpc') && @get_magic_quotes_gpc())
        {
            $var = stripslashes($var);
        }
        $var = addslashes($var);
        $var = htmlspecialchars($var);
        return($var);
    }
    
} // Line 66

?>

If you wan't the class i'm extending then here it is, i got a little help from Kalle;

PHP Code:


			
<?php
//Check if ticket
if (!defined('BACKEND_TICKET'))
{
    die();
}

class p101 
{
    
    protected $instances = array();
    
    public function __construct() 
    {
        
        // Load classes
        
        foreach(glob(CLASS_PATH . '*.class.php') as $filename) 
        {
            if (!is_readable($filename)) 
            {
                
                $this->error[] = 'File: ' . $filename . ' is not readable';
                continue;
            }
                require($filename);
                
                //$classname = substr($filename, strlen(CLASS_PATH), strpos($filename, '.', 0));
                $classname = explode('/', $filename);
                $classname = end($classname);
                $classname = explode('.', $classname);
                $classname = $classname[0];

                if (class_exists($classname)) 
                {
                    $this->instances[$classname] = new $classname;
                } else 
                {
                    $this->error[] = 'Problem declaring ' . $classname;
                }
        }
        
        
        // Clean globals
        $this->clean->clean_globals();

    }
    
    public function __get($varname) 
    {
        $varname = (string) $varname;

        if(array_key_exists($varname, $this->instances))
        {
            return($this->instances[$varname]);
        }
        elseif(isset($this->{$varname}))
        {
            return($this->{$varname});
        }
    }
}

?>

I'm pretty stuck with this at the moment. Any suggestions?

Wildhoney · 06-05-2008, 07:18 PM

My guess is that you're including the file that contains the clean class twice.

SpYkE112 · 06-05-2008, 07:22 PM

But i don't the only place it gets included is in the __constructer :/
This is really annoying ^_^

delayedinsanity · 06-05-2008, 07:27 PM

I don't know about other people, but I once accidentally tried instantiating an extension of a class from within the class that it was extending, and it would kill apache everytime. I don't think you're supposed to be allowed to do that. (To break it down, it looks like even though clean extends p101, you're calling clean from within p101)
-m

SpYkE112 · 06-05-2008, 07:33 PM

I'm pretty new to the whole OOP thing, so could you break it down so that a 3 year old would understand it??

delayedinsanity · 06-05-2008, 07:58 PM

Well my first question would be, do you really need to extend p101? It looks to me like they're two completely different beasts, ie, p101() intializes your classes and adds objects to a library, whereas clean() is meant for sanitizing strings/variables. When you extend a class in Object Oriented Programming it's generally so that the child class can use some method or property of the parent/super class in conjunction with new methods that it defines. If the two classes don't use any similar properties or methods, and in this case, don't even really do the same thing, there shouldn't be a need to create the child->parent relationship of an extended class.

Um, and I don't want to insult your intelligence because I'm sure you can keep up, but broken down for a three year old, I guess I would say something along the lines of.... well, spyke, that's a question you should be asking your mom.
-m

SpYkE112 · 06-05-2008, 08:05 PM

Well, the plan is to start creating somekind of Framework thingy, where i wan't to use the class p101 as an umbrella, from where i can call every other class, and then i wan't it to be like, you class p101, class A and class B. Then i wan't it to be able to use functions from A in B it the plan is that everthing gets "called" through class p101..

It is still very much work in progress as i'm very fresh in the entire OOP world :)

I hope you understand my little plan ^_^

delayedinsanity · 06-05-2008, 08:29 PM

Kind of a chained singleton. You still don't need to extend anything at this point though, since you'll be able to call clean a la

PHP Code:


			
$pUmbrella = new p101();
$pUmbrella->clean->clean_var($szString);

You may want to consider if you need to include and instantiate EVERY object on every page, every time. It seems like I'm doing this a lot lately, I feel kind of like a registryvangelist, but check this noise out: Registry pattern and definitely The Singleton Design Pattern for PHP <-- the singleton and registry are two of the easiest OOP design patterns to implement, but that's not to say they lack any power, as you'll find scripts all the way up to the Zend Framework using them.

If you want a great book on PHP object orientation and design patterns, take a peek at:
APRESS.COM : PHP Objects, Patterns, and Practice, Second Edition : 9781590599099

That book and Pro PHP are snazzy.
-m

SpYkE112 · 06-06-2008, 05:44 AM

Well, i looked at you links and decided to do it my own way, to ensure readabilty to me, and so that i know it works :)