Getting maaad :P

Tanax · 04-03-2008, 02:00 PM

So, seriously.. what's wrong with this function?

php Code:

public function getPoems($status = null) {
            
            if($status == 'active') {
                
                $sql = sprintf("    SELECT
                                        *
                                    FROM
                                        `%s`
                                    WHERE
                                        `%s` = 'active'
                                    ORDER BY
                                        `%s`
                                    ASC",
                                        
                                    $this->db->table['poems'],
                                    $this->db->col['poem_status'],
                                    $this->db->col['poem_order']);
                                    
            }
            
            elseif($status == null) {
                
                $sql = sprintf("    SELECT
                                        *
                                    FROM
                                        `%s`
                                    ORDER BY
                                        `%s`
                                    ASC",
                                        
                                    $this->db->table['poems'],
                                    $this->db->col['poem_order']);
                
            }
                                
            $query = $this->db->query($sql);
            
            if($query) {
                
                while($results = mysql_fetch_array($query)) {
                    
                    $array[] = $results;
                    
                }
                
                return $array;
                
            }
            
            return false;
            
        }

php Code:

$poemlist = $tanaxia['poems']->getPoems();

    foreach($poemlist as $a) {
        
        foreach($a as $b) {
            
            echo $b;
            echo '<br />';
            
        }
        
    }

echoes:

Quote:

1
1
active
active
1
1
Test
Test
I'm just testing this poem..
I'm just testing this poem..
gpwgjwpegwepgjwpegjwpgwoejgpwegjwpeg
gpwgjwpegwepgjwpegjwpgwoejgpwegjwpeg

YES, it echoes 2 of everything, but there only really exists 1 entry in the database.

So WHY oh WHY does it echo out 2 of everything?
Something's messed up with that array that the getPoems() function returns =//

Salathe · 04-03-2008, 04:17 PM

Most likely, this problem is with your use of mysql_fetch_array (PHP Manual page). You don't provide any value for the second argument (result_type), so it falls back to the default which is MYSQL_BOTH (other allowed values are MYSQL_ASSOC and MYSQL_NUM). Because of this, the fetched array will contain both the numeric (the column number) and associative (the column name) keys into the result.

To fix the behaviour for your needs, you need to put in one of MYSQL_NUM/ASSOC as the second argument -- most likely MYSQL_ASSOC for most normal usage.

Just to get an idea of what's going on for your own learning, try the following with using the different constants and see what they return. You'll understand clearly if you do that.

PHP Code:


			
$poemlist = $tanaxia['poems']->getPoems();
print_r($poemlist);

Tanax · 04-03-2008, 06:06 PM

Quote:

Originally Posted by Salathe

Most likely, this problem is with your use of mysql_fetch_array (PHP Manual page). You don't provide any value for the second argument (result_type), so it falls back to the default which is MYSQL_BOTH (other allowed values are MYSQL_ASSOC and MYSQL_NUM). Because of this, the fetched array will contain both the numeric (the column number) and associative (the column name) keys into the result.

To fix the behaviour for your needs, you need to put in one of MYSQL_NUM/ASSOC as the second argument -- most likely MYSQL_ASSOC for most normal usage.

Just to get an idea of what's going on for your own learning, try the following with using the different constants and see what they return. You'll understand clearly if you do that.

PHP Code:


			
$poemlist = $tanaxia['poems']->getPoems();

print_r($poemlist);

Yes, it works now

Thanks

I already tried with print_r and var_dump but none of them made sense to me at the time

Anyways, it's strange, because I don't have to do this on all my mysql_fetch_array queries =//