[Village Idiot]

Some things I noticed:
-Severe lack of comments, makes the script near unreadable.

-Every command doesnt need to have three lines between it, just makes it look messy.

-You have an entire HTML page on your PHP page, that defeats the purpose of a templating system.

[khile]

I understand i have made quite a few mistake if anyone is interested please join msn me or post a comment as more the merer

as im using this as a learning curve

[Wildhoney]

Fair play to you as well for trying such a mammoth task. I'm not sure I'd be able to successfully code a forum just yet. It's certainly a big, BIG job.

[khile]

thank i think i bitten off more than i can chew i am in desperate need of some BBCode righting and would be greatful for some help if at all possible

[Wildhoney]

I actually wrote a class for BB code, but I don't think Karl'd appreciate me handing it out, unfortunately. The following should give you a good idea. It does the bold, italic and underline for you:

PHP Code:

$szText = 'This is [u]a[/u] [b]test for bold[/b].';

$szText = preg_replace('~\[b\](.+?)\[/b\]~i', '<b>\\1</b>', $szText);
$szText = preg_replace('~\[i\](.+?)\[/i\]~i', '<i>\\1</i>', $szText);
$szText = preg_replace('~\[u\](.+?)\[/u\]~i', '<u>\\1</u>', $szText);

echo $szText; 


[khile]

Well below is my current BB code and as you can see its a mess

would be a help if someone could devote a little time to it ill mention you in credits

PHP Code:

<?PHP
function aeoncode($message,$theme){

$badword_sql = mysql_query("SELECT * FROM ". $tbl_prefix ."wordfilters");
while($word_row = mysql_fetch_array($badword_sql)){
    $word = $word_row["word"];
    $replacement = $word_row["replacement"];

    $message = str_replace($word, $replacement, $message);
}
    $message = str_replace("$", "$", $message);
    $message = str_replace(Chr(13), " <br> ", $message);
while (preg_match('#\[hilight\](.*?)\[/hilight\]#is', $message)){
    $message = preg_replace('#\[hilight\](.*?)\[/hilight\]#is', '<span class=hilight_str>\\1</span>', $message);
}
while (preg_match('#\[b\](.*?)\[/b\]#is', $message)){
    $message = preg_replace('#\[b\](.*?)\[/b\]#is', '<b>\\1</b>', $message);
}
while (preg_match('#\[i\](.*?)\[/i\]#is', $message)){
    $message = preg_replace('#\[i\](.*?)\[/i\]#is', '<i>\\1</i>', $message);
}
while (preg_match('#\[u\](.*?)\[/u\]#is', $message)){
    $message = preg_replace('#\[u\](.*?)\[/u\]#is', '<u>\\1</u>', $message);
}
    $message = preg_replace('#\[big\](.*?)\[/big\]#is', '<big>\\1</big>', $message);
    $message = preg_replace('#\[sm\](.*?)\[/sm\]#is', '<small>\\1</small>', $message);


    $smilie_folder = 'templates/'. $theme .'/images/smilies/';

    if(file_exists($smilie_folder)) {

        $message = str_replace(':P', '<img alt="smilie for :P" title=":P" src="'
        .$smilie_folder.'tongue.gif" vspace="1" hspace="1">', $message);
        $message = str_replace(':p', '<img alt="smilie for :p" title=":p" src="'
        .$smilie_folder.'tongue.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':d', ' <img alt="smilie for :d" title=":d" src="'
        .$smilie_folder.'grin.gif" vspace="1" hspace="1"> ', $message);
        $message = str_replace(':D', '<img alt="smilie for :D" title=":D" src="'
        .$smilie_folder.'grin.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':sleep:', '<img alt="smilie for :sleep:" title=":sleep:" src="'
        .$smilie_folder.'sleeping.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':)', '<img alt="smilie for :)" title=":)" src="'
        .$smilie_folder.'excited.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':(', '<img alt="smilie for :(" title=":(" src="'
        .$smilie_folder.'dissapointed.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':sad:', '<img alt="smilie for :sad:" title=":sad:" src="'
        .$smilie_folder.'sad.gif" vspace="1" hspace="1">', $message);

        $message = str_replace(':O', '<img alt="smilie for :O" title=":O" src="'
        .$smilie_folder.'shocked.gif" vspace="1" hspace="1">', $message);
        $message = str_replace(':o', ' <img alt="smilie for :o" title=":o" src="'
        .$smilie_folder.'shocked.gif" vspace="1" hspace="1">', $message);

        $message = str_replace('-.-', '<img alt="smilie for -.-" title="-.-" src="'
        .$smilie_folder.'closedeyes.gif"> ', $message);

        $message = str_replace('o.o', '<img alt="smilie for o.o" title="o.o" src="'
        .$smilie_folder.'bigeyes.gif" vspace="1" hspace="1">', $message);
        $message = str_replace('O.O', '<img alt="smilie for o.o" title="o.o" src="'
        .$smilie_folder.'bigeyes.gif" vspace="1" hspace="1">', $message);
        $message = str_replace('O.o', '<img alt="smilie for o.o" title="o.o" src="'
        .$smilie_folder.'bigeyes.gif" vspace="1" hspace="1">', $message);
        $message = str_replace('o.O', '<img alt="smilie for o.o" title="o.o" src="'
        .$smilie_folder.'bigeyes.gif" vspace="1" hspace="1">', $message);
    }

$url_start = "<a target=_blank href=";
$url_close = ">";
$img_start = "<img border=0 src=";
$img_close = " alt=\"AEONboard Image\">";
$quote_start = "<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=quotetop>Quote</td></tr><tr><td class=quotemain style=\"overflow: auto;\">";
$quote_close = "</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>";
$code_start = "<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=codetop>Code</td></tr><tr><td class=codemain style=\"overflow: auto;\">";
$code_close = "</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>";
$any = "(.*?)";
$matches="";

preg_match_all("#\[url\](.*?)\[/url\]#is", $message, $matches);
foreach ($matches[1] as $match_now) {
    if (preg_match("#^http://(www\.)?[a-z0-9\-]+(\.[a-z0-9\-]+\.[a-z]{1,4}|\.[a-z]{1,4})#is", $match_now)) {
        $message = str_replace('[url]'.$match_now.'[/url]', '<a href="'.$match_now.'" target="_blank">'.$match_now.'</a>', $message);
    }
}

preg_match_all("#\[url\=(.*?)\](.*?)\[/url\]#is", $message, $matches);
for ($i=0;$i<count($matches[1]);$i++) {
    if (preg_match("#^http://(www\.)?[a-z0-9\-]+(\.[a-z0-9\-]+\.[a-z]{1,4}|\.[a-z]{1,4})#is", $matches[1][$i])) {
        $message = str_replace('[url='.$matches[1][$i].']'.$matches[2][$i].'[/url]', '<a href="'.$matches[1][$i].'" target="_blank">'.$matches[2][$i].'</a>', $message);
    }
}

preg_match_all("#\[img\](.*?)\[/img\]#is", $message, $matches);
foreach ($matches[1] as $match_now) {
    if (preg_match("#^[url]http://(www\.)?[/url][a-z0-9\-]+(\.[a-z0-9\-]+\.[a-z]{1,4}|\.[a-z]{1,4})#is", $match_now)) {
        $message = str_replace('[img]'.$match_now.'[/img]', $img_start.$match_now.$img_close, $message);
    }
}

preg_match_all("#\[img=(.*?)\]#is", $message, $matches);
foreach ($matches[1] as $match_now) {
    if (preg_match("#^[url]http://(www\.)?[/url][a-z0-9\-]+(\.[a-z0-9\-]+\.[a-z]{1,4}|\.[a-z]{1,4})#is", $match_now)) {
        $message = str_replace('[img='.$match_now.']', $img_start.$match_now.$img_close, $message);
    }
}
/*if (eregi('http://', $message)){
$message = preg_replace("#\[url\](.*?)\[/url\]#is", '<a href="\\1" target=_blank>\\1</a>', $message);
$message = preg_replace("#\[url=$any\]$any\[/url\]#is", "<a href=\"\\1\" target=_blank>\\2</a>", $message);
} else {
$message = preg_replace("#\[url\](.*?)\[/url\]#is", '<a href="http://\\1" target=_blank>\\1</a>', $message);
$message = preg_replace("#\[url=$any\]$any\[/url\]#is", "<a href=\"http://\\1\" target=_blank>\\2</a>", $message);
}

    $message = preg_replace("#\[img\]$any\[/img\]#is","$img_start\\1$img_close",$message);    
    $message = preg_replace("#\[img=$any\]#is","$img_start\\1$img_close",$message);
*/
while (preg_match('#\[quote=(.*)\](.*)\[/quote\]#is', $message)){
$message = preg_replace('#\[quote=(.*?)\](.*?)\[/quote\]#is', '<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=quotetop>Quote - \\1</td></tr><tr><td class=quotemain style=\"overflow: auto;\">\\2</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>', $message);
}




while (preg_match('#\[quote\](.*)\[/quote\]#is', $message)){
    $message = preg_replace('#\[quote\](.*?)\[/quote\]#is', "$quote_start\\1$quote_close", $message);
}

while (preg_match('#\[code\](.*)\[/code\]#is', $message)){
    $message = preg_replace('#\[code\](.*?)\[/code\]#is', "$code_start\\1$code_close", $message);
}
    return ($message );
}


function pmcode($message){
    $message = htmlspecialchars($message);

$badword_sql = mysql_query("SELECT * FROM ". $tbl_prefix ."wordfilters");
while($word_row = mysql_fetch_array($badword_sql)){
    $message = eregi_replace($word_row[word],$word_row[replacement],$message);
}

$redtable_start = "<center><table width=90% class=pm_codetop>
        <tr><td style=\"overflow: auto;\">";
$redtable_close = "</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>";

    $message = str_replace("$", "$", $message);
    $message = str_replace(Chr(13), " <br> ", $message);

while (preg_match('#\[redtable\](.*?)\[/redtable\]#is', $message)){
    $message = preg_replace('#\[redtable\](.*?)\[/redtable\]#is', $redtable_start .'\\1'. $redtable_close, $message);
}
while (preg_match('#\[hilight\](.*?)\[/hilight\]#is', $message)){
    $message = preg_replace('#\[hilight\](.*?)\[/hilight\]#is', '<span class=hilight_str>\\1</span>', $message);
}
while (preg_match('#\[b\](.*?)\[/b\]#is', $message)){
    $message = preg_replace('#\[b\](.*?)\[/b\]#is', '<b>\\1</b>', $message);
}
while (preg_match('#\[i\](.*?)\[/i\]#is', $message)){
    $message = preg_replace('#\[i\](.*?)\[/i\]#is', '<i>\\1</i>', $message);
}
while (preg_match('#\[u\](.*?)\[/u\]#is', $message)){
    $message = preg_replace('#\[u\](.*?)\[/u\]#is', '<u>\\1</u>', $message);
}
    $message = preg_replace('#\[big\](.*?)\[/big\]#is', '<big>\\1</big>', $message);
    $message = preg_replace('#\[sm\](.*?)\[/sm\]#is', '<small>\\1</small>', $message);

$url_start = "<a target=_blank href=";
$url_close = ">";
$img_start = "<img border=0 src=";
$img_close = " alt=\"AEONboard Image\">";
$quote_start = "<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=pm_codetop>Quote</td></tr><tr><td class=pm_codecontent style=\"overflow: auto;\">";
$quote_close = "</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>";
$code_start = "<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=pm_codetop>Code</td></tr><tr><td class=pm_codecontent style=\"overflow: auto;\">";
$code_close = "</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>";
$any = "(.*?)";



if (eregi('http://', $message)){
    $message = preg_replace("#\[url\](.*?)\[/url\]#is", '<a href="\\1" target=_blank>\\1</a>', $message);
    $message = preg_replace("#\[url=$any\]$any\[/url\]#is", "<a href=\"\\1\" target=_blank>\\2</a>", $message);
} else {
    $message = preg_replace("#\[url\](.*?)\[/url\]#is", '<a href="http://\\1" target=_blank>\\1</a>', $message);
    $message = preg_replace("#\[url=$any\]$any\[/url\]#is", "<a href=\"http://\\1\" target=_blank>\\2</a>", $message);
}



while (preg_match('#\[quote=(.*)\](.*)\[/quote\]#is', $message)){
    $message = preg_replace('#\[quote=(.*?)\](.*?)\[/quote\]#is', '<center><table width=90% border=0 cellpadding=1 cellspacing=0>
        <tr><td class=pm_codetop>Quote - \\1</td></tr><tr><td class=pm_codecontent>\\2</td></tr></table>
        <table border=0 width=100%><tr><td height=5></td></tr></table></center>', $message);
}


    $message = preg_replace("#\[img\]$any\[/img\]#is","$img_start\\1$img_close",$message);
    $message = preg_replace("#\[img=$any\]#is","$img_start\\1$img_close",$message);

while (preg_match('#\[quote\](.*)\[/quote\]#is', $message)){
    $message = preg_replace('#\[quote\](.*?)\[/quote\]#is', "$quote_start\\1$quote_close", $message);
}

while (preg_match('#\[code\](.*)\[/code\]#is', $message)){
    $message = preg_replace('#\[code\](.*?)\[/code\]#is', "$code_start\\1$code_close", $message);
}
    return ($message );
}

?>

[Gareth]

I have sent you a PM, with help.
Gareth

[khile]

Originally Posted by Gareth

I have sent you a PM, with help.
Gareth

yea just got your message thanks

[Kalle]

Hmm If it wasn't for I've just started to develop my own forums a couple of weeks ago I would have helped out.

And as the other said something of the minusses in your code, then I would recommed you to either use a database access component or a database actraction layer to handle different database systems which makes your software more portable ;)

[Tanax]

@wildhoney- A forum is quite easy actually. But to make a GOOD software forum, it's a big task.

[Village Idiot]

A forum is an advanced project, I dont consider doing it bad doing it at all. For such an advanced project, so many newbies do it. I did one in late 2005, look how it turned out
http://www.justanotherportfolio.com/forum.zip

Note:
-The cookie was formatted as "username|pass|id|rank" unencrypted
-All the posts where assigned to an array in a loop, then displayed in another
-The mysql didnt use auto_increment, I assigned the ID based off of the number of rows in the database. I just didnt delete anything to keep it working.

I would show you the version still on the web, but its been hacked over and is now unusable.

PHP Code:

<html>
<head>
<title>Untitled Document</title>
<link rel="stylesheet" type="text/css" href="css.css" />

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>

<?php

mysql_connect("localhost","name","pass");
mysql_select_db("db");

//get and check the login cookie

$login_cookie = $_COOKIE["login_cookie"];


$login_info = explode('|',$login_cookie);

$login_sn = $login_info[0];
$login_pass = $login_info[1];
$login_id = $login_info[2];
$login_rank = $login_info[3];


$loginresult = mysql_query("SElECT * FROM user_tbl WHERE user_id = '$login_id'");
$sqlpass = mysql_result($loginresult,'0',"user_pass");
$sqlrank = mysql_result($loginresult,'0',"user_type_id");
$avatar = mysql_result($loginresult,'0',"user_avatar");


//check pass
//if($login_pass != $sqlpass)
//{
//die("please log in");
//}


$id = $_GET["forum_id"];
$topic_id = $_GET["topic"];

//assign the nessesary data
$all_resp_data = mysql_query("SELECT * FROM board_response_tbl WHERE resp_question_id = '$topic_id' AND resp_response_active = '1' ORDER BY resp_response_id ASC");
$resp_count = mysql_num_rows($all_resp_data);

$all_question_data = mysql_query("SELECT * FROM board_question_tbl WHERE ques_question_id = '$topic_id'");
$topic_origin_post2 = mysql_result($all_question_data,'0',"ques_question_txt");
$allow_replys = mysql_result($all_question_data,'0',"ques_allow_responses");
$topic_origin_post = nl2br($topic_origin_post2);

$user_posts = mysql_query("SELECT * FROM board_response_tbl WHERE resp_response_by = 'login_id'");
$user_post_count = mysql_num_rows($user_posts);


//nav data
$nav_forum = mysql_query("SELECT * FROM board_forum_tbl WHERE forum_id = '$id'");
$nav_forum_name = mysql_result($nav_forum,'0',"forum_name");

$nav_topic = mysql_query("SELECT * FROM board_question_tbl WHERE ques_question_ID = '$topic_id'");
$nav_topic_name = mysql_result($nav_topic,'0',"ques_question_name");

//get the ranks
if($login_rank == 0)
{
$rank = "master";
}

if($login_rank == 1)
{
$rank = "admin";
}

if($login_rank == 2)
{
$rank = "moderator";
}

if($login_rank == 3)
{
$rank = "user";
}

//assign the side data
$post_sider = "$login_sn<BR><img src = \"$avatar\" alt = \"avatar\" width=\"90\" height=\"78\"> <br><h6>user posts: $user_post_count <br>rank: $rank <br></h6> 
";

$post = array();
$post_maker = array();
$date_posted = array();
$post_id = array();
$post_text = array();

#assign the data in the arrays
for($loop=0;$loop<$resp_count;$loop++)
{
    $post_text[$loop] = mysql_result($all_resp_data,$loop,"resp_response_txt");
    $post_maker[$loop] = mysql_result($all_resp_data,$loop,"resp_response_by");
    $date_posted[$loop] = mysql_result($all_resp_data,$loop,"resp_create_dt");
    $post_id[$loop] =  mysql_result($all_resp_data,$loop,"resp_response_id");
    $post[$loop] = mysql_result($all_resp_data,$loop,"resp_response_txt");
}


//see what the edition options will be
if($login_rank <4)
{
$topic_options = "<a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/edittopic.php?topic_id=$topic_id\">edit topic</a>";
}


#--------------------------------------
#------------display data--------------
#--------------------------------------

//now display the data


//display the top navagation
echo "<a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/\">index</a> >> 
      <a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/gentopic.php?forum=$id\"> $nav_forum_name</a> >>
      <a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/genmessage.php?forum=$id&topic=$topic_id\"> $nav_topic_name</a><BR>";


echo "<table width=\"742\" border=\"5\">
  <tr> 
    <td width=\"157\" height=\"127\" valign=\"top\">$post_sider</td>
    <td width=\"567\" rowspan=\"2\" valign=\"top\">$topic_origin_post</td>
  </tr>
  <tr> 
    <td height=\"11\"></td>
  </tr>
  <tr> 
    <td height=\"33\" colspan=\"2\" valign=\"top\">$topic_options</td>
    </tr>
  <tr>
    <td height=\"2\"></td>
    <td></td>
  </tr>
</table><BR>";


for($loop2=0;$loop2<$resp_count;$loop2++)
{
$post_id = mysql_result($all_resp_data,$loop2,"resp_response_id");

if($login_rank <4)
{
$options = "<a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/mark.php?post_id=$post_id&forum=$id&topic_id=$topic_id\">report to moderator</a> <a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/editpost.php?post_id=$post_id&forum=$id&topic_id=$topic_id\">edit post</a>";
}

echo "
<table width=\"742\" border=\"5\">
  <tr> 
    <td width=\"157\" height=\"127\" valign=\"top\">$post_sider</td>
    <td width=\"567\" rowspan=\"2\" class = \"post\" valign=\"top\">$post[$loop2]</td>
  </tr>
  <tr> 
    <td height=\"11\"></td>
  </tr>
  <tr> 
    <td height=\"33\" colspan=\"2\" valign=\"top\">$options</td>
    </tr>
  <tr>
    <td height=\"2\"></td>
    <td></td>
  </tr>
<a name=\"$post_id\"></a>
</table><BR>";
}

if($allow_replys == 1)
{
echo "<BR><BR>
<a href = \"http://www.cfwebanalysts.com/L2W/nrc/nrcbb/postmessage.php?forum=$id&topic=$topic_id\">Post reply</a>";
}
else
{
echo "<B>topic LOCKED</B>";
}
mysql_close();
?>
</body>
</html>

[Matt]

Why are you still using that stolen layout?
Anyways, i now have my proof that this layout is NOT his.
EKINboard - (Powered By EKINboard)

[RobertK]

Right, because they couldn't possibly have stolen it from him---or even gotten it from the same designer. Designers have been known to relicense works if they were generic instead of branded. And that is not branded. Try contacting the project's webmaster and asking before jumping to conclusions, Matt.

That said, Khile, there is a good bit of risk for having a lookalike forum. You should check with your designer and make certain that it is a lookalike and not a rip. Stress that he has to have created all the graphics himself, or have used them with permission. I'd point to that package too, to make him sweat and hopefully be honest--if he was deceitful in the first place. If it is merely a lookalike, I'd make a forum post here and there announcing this and quoting your designer for safety.

[khile]

im trying to get in contact with designer and will suspend design indefinably till i can find out what's has happened

[Alan @ CIT]

I'm not trying to suggest anything, but the code for your index.php that you posted in this thread does look very similar to Ekinboards code (Ekinboard V1.0.3 - V1 / Cp.php - Free PHP Scripts).

Alan

[khile]

ok you caught me I have taken over development of ekinboard bought a few months back and have invested a lot of time into this as far as design goes I had that made by the origanal skiner of ekinboard for $ 200 I now see I have been ripped off to whitch he has not responded to any email.

Also ekinboard is now closed as jew to its bad reputation I thought best to start a fresh so to speak and renamed board witch was part of sale agreement. That's why code will look simulate but if you look mine is far moreadvanced noe with intire re-writes of files

[Alan @ CIT]

I want to believe you, I really do

Alan

[khile]

what dose that mean?

[Alan @ CIT]

It doesn't mean anything, you just don't seem like the sort of person who would spend a couple of thousand dollars buying the rights to some forum software with the intention of improving and selling/releasing it

But anyway, it's none of my concern or business so good luck with Aeonboard

Alan

[khile]

i did not spend a few thousand on it i spend $500 that around £250 and i do not have intent on selling it on i intend to develop and release under GPL