TalkPHP
 
 
Account Login
Latest Articles
» The basic usage of PHPTAL, a XML/XHTML template library for PHP
» Vulnerable methods and the areas they are commonly trusted in.
» Simple way to protect a form from bot
» The Basics On: How Session Stealing Works
» How to keep your forms from double posting data
IRC Channel
IRC Speech Bubble Join the friendly bunch on IRC...
(#TalkPHP on Freenode)

...Also available via a web interface.

See this thread for information on the TalkPHP Free Hugs Initiative™. Subject to availability.
Associates
Associates
CSS Tutorials
Reply
 
LinkBack Thread Tools Search this Thread Display Modes
Old 08-06-2010, 04:43 AM   #1 (permalink)
The Visitor
Newcomer 
 
Join Date: Aug 2010
Posts: 1
Thanks: 0
josiec09 is on a distinguished road
Default Upload script help

Ok i am building a php upload script for my image gallery and i am trying to make so if the file exists it will give an error and not upload. I know about "if (!file_exists()) {" but not sure where to add it in my code to get it working...

Any help would be great. Here is my code. Please don't change anything else in my code i will work on making it more Secure later.

Code:
<?php
//define a maxim size for the uploaded images in Kb
 define ("MAX_SIZE","1024"); 

//This function reads the extension of the file. It is used to determine if the file  is an image by checking the extension.
 function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
 }

//This variable is used as a flag. The value is initialized with 0 (meaning no error  found)  
//and it will be changed to 1 if an errro occures.  
//If the error occures the file will not be uploaded.
 $errors=0;
//checks if the form has been submitted
 if(isset($_POST['Submit'])) 
 {
 	//reads the name of the file the user submitted for uploading
 	$image=$_FILES['image']['name'];
 	//if it is not empty
 	if ($image) 
 	{
 	//get the original name of the file from the clients machine
 		$filename = stripslashes($_FILES['image']['name']);
 	//get the extension of the file in a lower case format
  		$extension = getExtension($filename);
 		$extension = strtolower($extension);
 	//if it is not a known extension, we will suppose it is an error and will not upload the file,  
	//otherwise we will do more tests
 if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif")) 
 		{
		//print error message
 			echo '<h1>Unknown extension!</h1>';
 			$errors=1;
 		}
 		else
 		{
//get the size of the image in bytes
 //$_FILES['image']['tmp_name'] is the temporary filename of the file
 //in which the uploaded file was stored on the server
 $size=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
	echo '<h1>You have exceeded the size limit!</h1>';
	$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
$avatar = $_POST['avatar'];
//the new name will be containing the full path where will be stored (images folder)
$newname="./forums/images/avatars/gallery/".$avatar."/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = copy($_FILES['image']['tmp_name'], $newname);
if (!$copied) 
{
	echo '<center>Upload unsuccessfull!</center>';
	$errors=1;
}}}}

//If no errors registred, print the success message
 if(isset($_POST['Submit']) && !$errors)
 {
     echo '<center>Your avatar has been uploaded!<br /><br />

<img src=../../'.$newname.'><br>
To view the Avatar Gallery go to "<a href="/forums/profile.php?mode=editprofile">Edit Profile</a>" go to the Avatar section and click "Show Gallery"!
<a href="/avatar/upload/">Upload</a> another avatar. 
</center>';
} else
include 'form.php';
	
 ?>
josiec09 is offline  
Reply With Quote
Old 08-08-2010, 06:02 PM   #2 (permalink)
The Contributor
 
Tim Dobson's Avatar
 
Join Date: Feb 2010
Posts: 69
Thanks: 16
Tim Dobson is on a distinguished road
Default

i am not 100% sure but i think you would put it here

$newname="./forums/images/avatars/gallery/".$avatar."/".$image_name;

This is the location of where it will be stored right?

so just before it you would scan to see if its already there and if it is then bail out
Tim Dobson is offline  
Reply With Quote
Old 08-10-2010, 10:58 PM   #3 (permalink)
The Acquainted
 
sjaq's Avatar
 
Join Date: Nov 2007
Location: Netherlands
Posts: 113
Thanks: 11
sjaq is on a distinguished road
Default

PHP Code:
<?php
    define 
("MAX_SIZE","1024"); 

    
$errors=0;
    if(isset(
$_POST['Submit'])) {
        
$image=$_FILES['image']['name'];
        if(
$image) {
            
$filename stripslashes($_FILES['image']['name']);
            
$extension strtolower(end(explode('.'$filename)));
            if (
current(explode('/'$_FILES['image']['type'])) != 'image') {
                echo 
'<h1>Unknown extension!</h1>';
                
$errors=1;
            } else {
                
$size=$_FILES['image']['size'];

                if (
$size MAX_SIZE*1024) {
                    echo 
'<h1>You have exceeded the size limit!</h1>';
                    
$errors=1;
                }

                
//we will give an unique name, for example the time in unix time format
                
$avatar $_POST['avatar'];
                
//the new name will be containing the full path where will be stored (images folder)
                
if(function_exists('sha1_file')) {
                    
$hash sha1_file($_FILES['image']['tmp_name']);
                } else if(
function_exists('md5_file')) {
                    
$hash md5_file($_FILES['image']['tmp_name']);
                } else { 
$hash $_FILES['image']['tmp_name']; }
                
                
$newname="./forums/images/avatars/gallery/".$avatar."/"$hash '.' $extension;
                
//we verify if the image has been uploaded, and print error instead
                
if(!file_exists($newname)) {
                    if (!
move_uploaded_files($_FILES['image']['tmp_name'], $newname)) {
                        echo 
'<center>Upload unsuccessfull!</center>';
                        
$errors=1;
                    }
                }
            }
        }
    }


    
//If no errors registred, print the success message
     
if(isset($_POST['Submit']) && !$errors) {
         echo 
'<center>Your avatar has been uploaded!<br /><br />

        <img src=../../'
.$newname.'><br>
        To view the Avatar Gallery go to "<a href="/forums/profile.php?mode=editprofile">Edit Profile</a>" go to the Avatar section and click "Show Gallery"!
        <a href="/avatar/upload/">Upload</a> another avatar. 
        </center>'
;
    } else {
        include 
'form.php';
    }
    
?>
sjaq is offline  
Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On

Similar Threads
Thread Thread Starter Forum Replies Last Post
Help required for multiple upload through OOP script dhaval Advanced PHP Programming 13 08-11-2009 04:24 PM
Part 2: Giving our Currency Conversion Script some Responsibility Wildhoney General 15 03-17-2009 01:53 PM
Random Avatar Script FaceDancer Script Giveaway 1 08-22-2008 05:47 AM
Preview: Upcoming Image Upload Script + Member System Gareth Show Off 2 07-10-2008 06:56 PM
hash() algorithm info script RobertK Script Giveaway 4 01-09-2008 03:00 PM


All times are GMT. The time now is 10:14 AM.

 
     

Powered by vBulletin® Version 3.6.8
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.1.0
Inactive Reminders By Icora Web Design