No data inserted into database. Am I wrongdoing it?

fairytale89 · 03-29-2010, 12:02 PM

I have a form named:"RegistrationForm.php". when i click the "submit button", there's a data inserted in the database (the prove is, there a new row in the database),
but there's no value from user textfield(ic_no,name,email...) that have been inserted.
It means like there's a row of data inserted but without value..

p/s- however, when i click the submit button, it successfully directed me to the "BookingForm.php" with all the session value...it's just that there's no data inserted into the database.

can someone straighten this up for me? am i doing wrong with the coding with the submit button?
here's the code

Code:

<?php
session_start();
$_SESSION['ic_no']=$ic_no;
$_SESSION['name']=$name;
$_SESSION['address']=$address;
$_SESSION['tel_no']=$tel_no;
$_SESSION['email']=$email;
?>


<html>
<body>

<form action="BookingForm.php" method="post">
  <p><strong>REGISTRATION FORM</strong></p>
  <table width="285" border="1">
    <tr>
      <th width="120" scope="row">Ic No :</th>
      <td width="149"><label>
        <input type="text" name="ic_no" id="ic_no" value="<?php $ic_no; ?>">
      </label></td>
    </tr>
    <tr>
      <th scope="row">Name :</th>
      <td><label>
        <input type="text" name="name" id="name" value="<?php $name; ?>">
      </label></td>
    </tr>
    <tr>
      <th scope="row">Address :</th>
      <td><label>
        <input type="text" name="address" id="address" value="<?php $address; ?>" >
      </label></td>
    </tr>
    <tr>
      <th scope="row">Contact No :</th>
      <td><label>
        <input type="text" name="tel_no" id="tel_no" value="<?php $tel_no; ?>">
      </label></td>
    </tr>
    <tr>
      <th scope="row">Email :</th>
      <td><label>
        <input type="text" name="email" id="email"  value="<?php $email; ?>">
      </label></td>
    </tr>
  </table>
  <input type="submit" name="submit" id="submit" value="Submit">
  <?php
$con = mysql_connect("localhost","root","password");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("ambos", $con);

mysql_query("INSERT INTO customer (ic_no, name, address, tel_no, email)
VALUES ('$_POST[ic_no]', '$_POST[name]', '$_POST[address]','$_POST[tel_no]','$_POST[email]')");
mysql_close($con);

</form>
 </body>
</html>

any ideas is really appreciated

khr2003 · 03-29-2010, 03:02 PM

if you are using the same file to process form data you have first to check if the form is being submitted:

PHP Code:


			
if($_POST['submit'])

{

mysql_query("INSERT INTO customer (ic_no, name, address, tel_no, email)

VALUES ('$_POST[ic_no]', '$_POST[name]', '$_POST[address]','$_POST[tel_no]','$_POST[email]')");



}

else

{

<form action="BookingForm.php" method="post">

  <p><strong>REGISTRATION FORM</strong></p>

  <table width="285" border="1">

    <tr>

      <th width="120" scope="row">Ic No :</th>

      <td width="149"><label>

        <input type="text" name="ic_no" id="ic_no" value="<?php $ic_no; ?>">

      </label></td>

    </tr>

    <tr>

      <th scope="row">Name :</th>

      <td><label>

        <input type="text" name="name" id="name" value="<?php $name; ?>">

      </label></td>

    </tr>

    <tr>

      <th scope="row">Address :</th>

      <td><label>

        <input type="text" name="address" id="address" value="<?php $address; ?>" >

      </label></td>

    </tr>

    <tr>

      <th scope="row">Contact No :</th>

      <td><label>

        <input type="text" name="tel_no" id="tel_no" value="<?php $tel_no; ?>">

      </label></td>

    </tr>

    <tr>

      <th scope="row">Email :</th>

      <td><label>

        <input type="text" name="email" id="email"  value="<?php $email; ?>">

      </label></td>

    </tr>

  </table>

  <input type="submit" name="submit" id="submit" value="Submit">

</form>

}

delayedinsanity · 03-29-2010, 06:12 PM

For the luv of gawd, please don't forget to verify your data before you enter it into a database. At the very VERY least you should be sanitizing it with mysql_real_escape_string();

You're attempting to insert a row using POST information that isn't populated at the time of the statement. When the form submits (to BookingForm.php) you should be checking on that page for valid POST data. If none is found send them back to the form, if it is found, checked for validity and passes, then insert your sanitized input into the database.

fairytale89 · 03-29-2010, 06:30 PM

i do know that right now i'm passing the raw data into the database, but this is just the basic for me to see whether the form inserting will function or not.

i'm planning to make the form validating/ verifying the data after make sure that it completely success insert data into the database