$_GET error

Tanax · 08-14-2009, 01:23 PM

Hi, I have a really weird error...

phpfile.php

PHP Code:


			


$year = $_GET['year'];

        

        if(is_numeric($year) || $year == 'current')

        {

        

            $file = 'subs/economy/' . $year;

            

            if(file_exists($temp->getFile($file))) 

            {

            

                $temp->view($file);

                

            }

            

            else

            {

            

                $data['msg'] = 'Sidan finns ej';

                $temp->view('error', $data);

            

            }

            

        }

        

        elseif(!isset($year))

        {

        

            $year = 'current';

            $temp->view('subs/economy/' . $year);

        

        }

        

        else

        {

        

            $data['msg'] = 'Sidan finns ej';

            $temp->view('error', $data);

        

        }

Viewing phpfile.php?year=2009 brings up the template subs/economy/2009.php. Viewing 2008.. well you get the point.

Problem is though, that if I'm just viewing phpfile.php it should set $year = 'current', but it gives me an undefined index error. Any ideas how I can set so if they give no parameter in the url, it should set the parameter to 'current'(it doesn't have to DISPLAY that in the url though)?

Salathe · 08-14-2009, 01:53 PM

You need to check if the year was provided, if not use current as a default.

PHP Code:


			
$year = isset($_GET['year']) ? $_GET['year'] : 'current';

Tanax · 08-14-2009, 03:36 PM

Yea, I tried like this:

PHP Code:


			
if(isset($_GET['year'])) $year = $_GET['year'];

But that didn't work. Your code worked however. So thanks!

adamdecaf · 08-14-2009, 05:40 PM

Quote:

Originally Posted by Tanax

Yea, I tried like this:

PHP Code:


			
if(isset($_GET['year'])) $year = $_GET['year'];

But that didn't work. Your code worked however. So thanks!

His worked because you were not setting a default value if none was found, so PHP was using a[n] ''. <-- {Blank Space}

Tanax · 08-14-2009, 08:44 PM

Ooh.. right.. thanks