Basic php form update mysql script

dp2 · 02-17-2009, 03:27 PM

I am attempting to build a php form to update my database

I can php read from but trying to put this data into a form that will update my database. Is proving difficult In this example the first part is reading ok I'm now trying to get the data into the form fields, What is happerning is the data and variables are being erased.

Any ideas where I am going wrong? Thank you

Code:

<HTML>
<HEAD>
<TITLE> The Reg Directory </TITLE>
<HEAD>
<BODY>
<?php 

$dbcnx = @mysql_connect("localhost", "username", "password");
if (!$dbcnx) {
  echo( "<P>Unable to connect to the" .
        "database server at this time.</P>" );
  exit();
}

//select which database you want to edit
mysql_select_db("aynsley_phpbb1",$dbcnx);

if (! @mysql_select_db("aynsley_phpbb1") ) {
  echo( "<P>Unable to locate the regdir " .
        "database at this time.</P>" );
  exit();
}

 // Request the text of all the business names
  $result = mysql_query(
            "SELECT BusinessName FROM regdir");
  if (!$result) {
    echo("<P>Error performing query: " .
         mysql_error() . "</P>");
    exit();
  }
//mysql_query(<query>, <connection id>);
while ($row=mysql_fetch_array($result)) {
  echo("<P>" . $row["BusinessName"] . "</P>");
}
?>
<P> Here are all the Businesses in our database: </P>
<BLOCKQUOTE>

<?php

 // Request the text of all the business names
  $result = mysql_query(
            "SELECT BusinessStreet FROM regdir");
  if (!$result) {
    echo("<P>Error performing query: " .
         mysql_error() . "</P>");
    exit();
  }

  // Display the text of each BusinessName in a paragraph
  while ( $row = mysql_fetch_array($result) ) {
  }
?>
<html>
<body>
<form method="post"action="<?php echo $PHP_SELF ?>">
<input type=text name="action" value="">
Business Name 
<input type=text name="BusinessName" value="<?PHP echo $BusinessName ?>"></br>
<input type=text name="BusinessStreet" value="<?PHP echo $BusinessStreet ?>">
<input type=submit name="submit" value="submit">
</form>
<?php
  echo("$BusinessStreet");
  

?>
</BLOCKQUOTE>
</BODY>
</HTML>

Krik · 02-17-2009, 07:06 PM

Well you have not defined "$BusinessName" or "$BusinessStreet". If you leave the code unchanged you would need to use $row[0], $row[1], ect.

Or you could use "list" or "foreach" to make variables with those names.

PHP Code:


			
while ( $row = mysql_fetch_array($result) ) {

list ($BusinessName, $BusinessStreet) = $row;

}

PHP Code:


			
while ( $row = mysql_fetch_array($result) ) {

    foreach ($row as $key => $value) {

    }

}

Also you need to have the data echoed inside the while or foreach loops. Else you will only get the last record that was returned.

PHP Code:


			
<?php

while ( $row = mysql_fetch_array($result) ) {

    foreach ($row as $key => $value) {

?>

    <input type=text name="BusinessName" value="<?PHP echo $BusinessName ?>"></br>

    <input type=text name="BusinessStreet" value="<?PHP echo $BusinessStreet ?>">

<?php

    }

}

?>

dp2 · 02-18-2009, 06:48 AM

Thank you for all your help.

This is what I have achieved with your suggestions.

It's nearly there BusinessName displays BusinessStreet 1 result and BusinessStreet displays BusinessName.

Next stage will it update?

Code:

<HTML>
<HEAD>
<TITLE> The Edit Directory Listing</TITLE>
<HEAD>
<BODY>
<?php 

$dbcnx = @mysql_connect("localhost", "username", "password");
if (!$dbcnx) {
  echo( "<P>Unable to connect to the" .
        "database server at this time.</P>" );
  exit();
}

//select which database you want to edit
mysql_select_db("aynsley_phpbb1",$dbcnx);

if (! @mysql_select_db("aynsley_phpbb1") ) {
  echo( "<P>Unable to locate the regdir " .
        "database at this time.</P>" );
  exit();
}

 // Request the text of all the business names
  $result = mysql_query(
            "SELECT BusinessName FROM regdir");
  if (!$result) {
    echo("<P>Error performing query: " .
         mysql_error() . "</P>");
    exit();
  }
//mysql_query(<query>, <connection id>);
while ($row=mysql_fetch_array($result)) {
list ($BusinessStreet, $BusinessName) = $row;
}
 // Request the text of all the business names
  $result = mysql_query("SELECT * FROM regdir");
  if (!$result) {
    echo("<P>Error performing query: " .
         mysql_error() . "</P>");
    exit();
  }

  // Display the text of each BusinessName in a paragraph
 while ( $row = mysql_fetch_array($result) ) {
list ($BusinessName, $BusinessStreet) = $row;
}  
?>
<html>
<body>
<form method="post"action="<?php echo $PHP_SELF ?>">
Business Name:
<input type=text name="BusinessName" value="<?PHP echo $BusinessName ?>"><br>
Business Street:
<input type=text name="BusinessStreet" value="<?PHP echo $BusinessStreet ?>"><br>

<input type=submit name="submit" value="submit">
</form>

</BLOCKQUOTE>
</BODY>
</HTML>

I have two queries going on one is not working no errors
Is there a simple method to read a complete row from 1 ID field

tony · 03-11-2009, 04:06 PM

Quote:

Originally Posted by dp2

I have two queries going on one is not working no errors
Is there a simple method to read a complete row from 1 ID field

you can read 1 row based on a value like this:

PHP Code:


			
$result = mysql_query("SELECT * FROM regdir WHERE BusinessID=".$id);

in the query above the * would retrieve all the fields in that row. And the &id would have to be a variable holding the id of the row you want to retrieve.

P.D. you might want to restructure your code so it could be more legible, because I can't tell but maybe there is something wrong with the way the form is display, because I don't think you need 2 queries for this.
Just an advice.