Image Uploading

code_junkie · 10-16-2008, 01:39 PM

I am trying to make an image upload script. This script needs to upload the image to a specific folder within the site, then write its info to mysql. I've searched and searched, done alot of reading however almost everything I've looked at is different from each other. Can anyone help me in the right direction with finding the correct way of doing this? I'm still trying to understand php and this project has confused the hell out of me. Any help will be greatly appreciated.

Lou_Gato · 10-16-2008, 02:34 PM

I can use this too. I hope someone offers you some info soon.!!!

Wildhoney · 10-16-2008, 03:32 PM

Here you go guys. A nice simplified example for you both. You don't have to check the extension, but it's most certainly advisable, so I've added it in for you. Simply add the extensions to the array and voila!

Any explanations needed, just ask

! Ensure you create the "uploads" folder, else the script will fail -- gracefully, of course.

code_junkie · 10-16-2008, 03:52 PM

I have an error from the code you provided.
Error as follows:
Fatal error: Uncaught exception 'Exception' with message 'Image "8-28-2008 001.jpg" could not be uploaded.' in /var/www/vhosts/domain.com/httpdocs/admin/image_handler.php:31 Stack trace: #0 {main} thrown in /var/www/vhosts/domain.com/httpdocs/admin/image_handler.php on line 31

sketchMedia · 10-16-2008, 04:12 PM

check the permissions of the uploads folder

code_junkie · 10-16-2008, 05:08 PM

Permission are 777 and still have the error.

Wildhoney · 10-16-2008, 05:35 PM

Remove the "at" sign (@) from the front of move_uploaded_file. That way you'll be able to see the raw PHP error of what's happening. That should tell you a bit more than my custom exception.

code_junkie · 10-16-2008, 05:50 PM

I took the @ out and made one small change and it worked. Small error on my part, needed to change path out of one folder to go into the uploads folder. Thanks alot for that script. Now I need to get working on making it the info to the db. Thanks again...

code_junkie · 10-16-2008, 06:11 PM

Ok, I was hoping I wouldn't have to do this. When the script runs, it uploads then writes to the table... Problem is when it writes the name of the image, its writing it as Object id #1. Any thoughts?

code_junkie · 10-16-2008, 06:20 PM

Spoke to soon and didn't stare at it enough. Got it working now. Thanks for everything

code_junkie · 10-16-2008, 07:14 PM

I got a quick question for you Wildhoney. My fried had a resize script laying around but does know how to use it. How would I implement it into the script you gave me?

PHP Code:


			
<?php

  $source_pic = 'images/source.jpg';

  $destination_pic = 'images/destination.jpg';

  $max_width = 200;

  $max_height = 200;

  $src = imagecreatefromjpeg($source_pic);

  list($width,$height) = getimagesize($source_pic);

  $x_ratio = $max_width/$width;

  $y_ration = $max_height/$height;

  

  if ($width <= $max_width) && ($height <= $max_height)

    {

      $tn_width = $width;

      $tn_height = $height;

    }

    

  else if (($x_ratio*$height) < $max_height))

    {

      $tn_height = ceil($x_ratio*$height);

      $tn_width=$max_width;

    }



  else

    {

      $tn_height = ceil($y_ration*$width);

      $tn_height = $max_height;

    }

    

  $tmp = imgcreatetruecolor ($tn_width,$tn_height);

  imagecopyresample($tmp,$src,0,0,0,0,$tn_width,$tn_height,$width,$height);

  imagejpeg($tmp,$destination_pic,100);

  imagedestroy($src);

  imagedestroy($tmp);

?>

Wildhoney · 10-17-2008, 01:07 AM

You would drop it into a function. However, you may use my function in which I use to resize the images. I'm not saying mine is better, as it's been a while since I wrote it, but I know how it works

!

You would call it like so:

php Code:

image_resize('left_2405181707586.jpg', 'left_2405181707586-resized.jpg', 400, 400);

The function:

php Code:

function image_resize($szSource, $szDestination, $iResizeWidth, $iResizeHeight)
{
    declare(ticks = 1)
    {
        $szExtension = pathinfo($szSource, PATHINFO_EXTENSION);
        
       switch($szExtension)
       {
          case('jpg'):   $pSource = imagecreatefromjpeg($szSource); break;
          case('jpeg'):  $pSource = imagecreatefromjpeg($szSource); break;
          case('gif'):   $pSource = imagecreatefromgif($szSource); break;
          case('wbmp'):  $pSource = imagecreatefromwbmp($szSource); break;
          case('png'):   $pSource = imagecreatefrompng($szSource); break;
       }
       
       $pResized = imagecreatetruecolor($iResizeWidth, $iResizeHeight);
       list($iWidth, $iHeight) = getimagesize($szSource);
        
       if(!imagecopyresampled($pResized, $pSource, 0, 0, 0, 0, $iResizeWidth, $iResizeHeight, $iWidth, $iHeight))
       {
          return false;  
       }

        switch($szExtension)
        {
          case('jpg'):   $pResult = imagejpeg($pResized, $szDestination, 100); break;
          case('jpeg'):  $pResult = imagejpeg($pResized, $szDestination, 100); break;
          case('gif'):   $pResult = imagegif($pResized, $szDestination); break;
          case('wbmp'):  $pResult = imagewbmp($pResized, $szDestination); break;
          case('png'):   $pResult = imagepng($pResized, $szDestination); break;
       }
       
        if($pResult)
        {
            return true;
        }
            
        return false;
    }
}

allworknoplay · 03-16-2009, 05:20 PM

Hello, I am having an issue with this script. I have not changed the code at all. I simply uploaded it and I got a parsing error here:

Parse error: parse error in /usr/local/apache/upload.html on line 17

I have my apache parsing HTML as PHP so I don't think that is the issue since the rest of my site works with HTML extension.

Just to make sure I renamed it back to .php and still got the error.

This is line #17:

Code:

/* Ensure the extension we're upload is allowed. */
	if (!in_array($szExtension, $aAllowedExtensions))
	{
		throw new Exception('Extension "' . $szExtension . '" has been disallowed.');
	}

It seems to be this line exactly:

throw new Exception('Extension "' . $szExtension . '" has been disallowed.');

Any idea's?

allworknoplay · 03-16-2009, 09:52 PM

Also one more question, should the UPLOAD directory be in a publicly accessible directory or in a private directory?

I'm not sure what the security concerns are?