Includes problem

Haris · 11-10-2007, 11:31 PM

I have index.php which has $var = 1;

I'm using the following function to include the template file.

function/function.php

PHP Code:


			
    public function display($szView)
    {
        if (file_exists('views/' . $szView . '.php'))
        {
            include('views/' . $szView . '.php');
        }
    }

The code of index.php is now:

PHP Code:


			
include('function/function.php');
$var = 1;
display('home');

home.php is

PHP Code:


			
echo $var;

But it doesn't echo the variable.

Directory structure.

- Root
- - function/function.php display() function is located here
- - views/home.php
- index.php

Why is the variables in index.php is not being parsed by home.php? When I simply include the file with include and not the function, it works.

Tanax · 11-10-2007, 11:51 PM

Well, I believe you only use "public" function in classes.
And as far as I see, you're not using a class.

So it should only be:

function name($aArgs) { }

Haris · 11-10-2007, 11:59 PM

Quote:

Originally Posted by Tanax

Well, I believe you only use "public" function in classes.
And as far as I see, you're not using a class.

So it should only be:

function name($aArgs) { }

It is a class.

Salathe · 11-11-2007, 12:56 AM

Since the view file (views/home.php) is included within the class method (display) then all variables within that view file will be in the scope (PHP Manual page) of that class method.

To make it work you have a few options. Your first option is to define $var as global in your view (or the display method) with global $var (which is a nasty way of handling the situation). Secondly, you could replace $var with $GLOBALS['var'] in your view file (I don't like this way). A third way would be to pass along the 'template variables' into the display method and extract them to be used in your view. I like this last way.

PHP Code:


			
// class
    public function display($szView, $aVars = array())
    {
        if (file_exists('views/' . $szView . '.php'))
        {
            // See http://php.net/extract for usage
            extract($aVars, EXTR_SKIP | EXTR_REFS);
            include('views/' . $szView . '.php');
        }
    }

// index
include('function/function.php');
$aTplVars        = array();
$aTplVars['var'] = 1;  // $var in view file
$aTplVars['foo'] = 'bar'; // $foo in view file
display('home', $aTplVars);

There are lots more possibilities, but lets see if you're comfortable with the above first.

Andy · 11-11-2007, 01:56 AM

A quick hack may be to use:

PHP Code:


			
global $var;

echo $var;

Both nasty and untested; but may work

Tanax · 11-11-2007, 10:00 AM

Quote:

Originally Posted by Haris

It is a class.

And how should we know that? You never said anything about it in your first post

....