please check my code

meshi · 10-22-2007, 03:46 PM

this is a pagination--

Code:

if ($numrows > 3)	
{
<tr><td colspan="6" align="center" height="20" class="table-list-title"><b>Total selected transactions: &nbsp;<? echo $numrows?>&nbsp;</b>
	
		$s=$start+1;
		$l=$start+20;
		echo "Viewing $s - $l ";
	if ($start > 0)
		{
			echo '<span class="char"><A href="'; echo $_SERVER["PHP_SELF"]; echo '?click=client_list.php&menu=1&start=0&limit=20">[First] </a></span>';			
		} 
		$prev=$start-$limit;
		$next=$start+$limit;
		if ($prev >= 0){
		echo '<span class="char"><A href="'; echo $_SERVER["PHP_SELF"]; echo '?click=client_list.php&menu=1&start='.$prev.'&limit='.$limit.'">< Previous </a></span>';			
		}
		$numofpages=$numrows/$limit;
		if(($numrows % $limit)!=0)
		$numofpages=$numofpages+1;		
		for($i=1,$start=0;$i<=$numofpages;$i++)
		{
		$start=$start+$limit;
		$last=$start-$limit;
		}
		if ($next < $numrows){
		echo '<span class="char"><A href="'; echo $_SERVER["PHP_SELF"]; echo '?click=client_list.php&menu=1&start='.$next.'&limit='.$limit.'">Next ></a></span>';			
		}
		echo '<span class="char"><A href="'; echo $_SERVER["PHP_SELF"]; echo '?click=client_list.php&menu=1&start='.$last.'&limit='.$limit.'">[Last]</a></span>';	
}

please correct my code...make it simpler and short....i know this is an absolute beginner code..

Gurnk · 10-22-2007, 06:48 PM

What errors are you getting?

Wildhoney · 10-22-2007, 11:02 PM

Pagination, I'm afraid, is prone to having so much code - there isn't a really easy way to do it. One question, however, why do you have so many missing PHP tags?

meshi · 10-23-2007, 06:48 AM

oh i see..i thought it has simplier solution than mine..thanx..

Salathe · 10-23-2007, 10:47 AM

You could certainly clear out some of the unnecessary code, but the basic structure would be essentially the same.

meshi · 10-30-2007, 05:15 PM

ok thanx.:)

bluesaga · 10-30-2007, 07:43 PM

PHP Code:


			
        function pagination($current_page, $num_of_pages)
        {
                        if($current_page > $num_of_pages)
                                $current_page = $num_of_pages;

                        if($current_page == "")
                                $current_page = 1;

                        if($current_page != 1)
                                $prev = $current_page - 1;

                        if($current_page != $num_of_pages)
                                $next = $current_page + 1;

                        $min = $current_page-5;
                        $max = $current_page+5;
                        if($min < 1)
                                $min = 1;
                        if($current_page < 6 && $num_of_pages < 10)
                                $max = $num_of_pages;
                        elseif($current_page < 6 && $current_page > 10)
                                $max = 10;

                        if($max > $num_of_pages)
                                $max = $num_of_pages;

                        if($prev != "")
                                $pagination[] = "P-".$prev;

                        for($i=$min; $i <= $max; $i++)
                        {
                                $pagination[] = $i;
                        }

                        if($next != "")
                                $pagination[] = "N-".$next;
                        return $pagination;
        }

With this function, you supply the current page number, and the total number of pages for the result set.

The function then returns an array which will be similar to this:

(If the current page is 2 and max pages = 5)
$pagination[0] = "P-1";
$pagination[1] = 1;
$pagination[2] = 2;
$pagination[3] = 3;
$pagination[4] = 4;
$pagination[5] = 5;
$pagination[6] = "N-3";

Usage example:

PHP Code:


			
$curr_page = 2;
$total_pages = 5;

$page = pagination($curr_page, $total_pages);
        foreach($pages as $page)
        {
                //print $page;
                if (stripos($page, "p-") !== false)
                {
                        $p = substr($page, -1);
                        if($p != 1)
                         print "<a href='/".$p."/".urlencode($search)."'>Prev</a>";
                        else
                         print "<a href='/".urlencode($search)."'>Prev</a>";
                }
                elseif(stripos($page, "n-") !== false)
                {
                        $p = substr($page, -1);
                        print "<a href='/".$p."/".urlencode($search)."'>Next</a>";
                }
                else
                {
                  if($page != 1)
                        print "<a href='/".$page."/".urlencode($search)."'>".$page."</a>";
                  else
                        print "<a href='/".urlencode($search)."'>".$page."</a>";
                }
        }

Note, i apologise for not using the standardised prefixes to variables with this example. I created it before i myself started using them.

meshi · 11-01-2007, 04:38 PM

thank you bluesaga.:)