TalkPHP - View Single Post

Karl · 01-06-2008, 04:57 PM

I too followed the first method for some time, but also changed to the latter for the exact same reason. However, now I've updated my monitor it doesn't really bother me either way.

The only downside to the second method is that the blocks kind of look like functions at a glance, but that is really a very minor hindrance. There is another alternative:

PHP Code:


			
$this->m_aAccounts[$szUsername] = array(
    'username' => $szUsername,
    'password' => $szPassword,
    'level_name' => $pLevel->getLevelName(),
    'level_flags' => $pLevel->getLevelFlags());

It's pretty much the same as your second method but without placing the opening and closing brackets on their own line. I think that removes the relation to the function and still provides a good solution. Thoughts?

01-06-2008, 04:57 PM	#2 (permalink)
Karl The Reckoner Join Date: Sep 2007 Posts: 437 Thanks: 22	I too followed the first method for some time, but also changed to the latter for the exact same reason. However, now I've updated my monitor it doesn't really bother me either way. The only downside to the second method is that the blocks kind of look like functions at a glance, but that is really a very minor hindrance. There is another alternative: PHP Code: `$this->m_aAccounts[$szUsername] = array( 'username' => $szUsername, 'password' => $szPassword, 'level_name' => $pLevel->getLevelName(), 'level_flags' => $pLevel->getLevelFlags());` It's pretty much the same as your second method but without placing the opening and closing brackets on their own line. I think that removes the relation to the function and still provides a good solution. Thoughts? __________________ Any fool can write code that a computer can understand. Good programmers write code that humans can understand.