View Single Post
Old 08-01-2009, 04:08 PM   #90 (permalink)
ETbyrne
how quixotic are you?
 
ETbyrne's Avatar
 
Join Date: Dec 2007
Location: Lapeer, MI
Posts: 445
Thanks: 37
ETbyrne is on a distinguished road
Default

@ioan1k, that's an interesting idea I'll definitely look into that.

@Salathe, I could add the $columns argument to the select() method, that would be really easy to do.

The thing is with mixing the ORDER BY method with the DESC method is that what if you happen to have a table column named "desc"? I know that's very unlikely to happen but I'm trying to keep it as straight forward as possible without creating any design limitations.

The same thing goes for ioan1k's idea of putting the "-" and ">" in with the value, what if you had some data that started with a ">" or a "-"? Not only does it impose design limitations and add to the complexity of the driver, it also opens the system up to new kinds of SQL injection.

I think that something like this should be simple enough for the developer to understand:

PHP Code:
$data $table->select('col1','col2','col3')
      ->
where('name','!=','Joe')
      ->
order('name','id')
      ->
desc()
      ->
execute(); 
Also, it just so happened that with the way the driver was built that it allowed all three of those methods to work. I'm not planning on throwing all of them at the user.
__________________
Dingo Web Systems > http://www.dingocode.com
My Website > http://www.evanbot.com
ETbyrne is offline  
Reply With Quote