Dingo Framework - ALPHA Testing Open!
View Single Post
04-11-2009, 11:43 PM
Join Date: Sep 2007
I just read abit more on the code, system/classes/files.php:
No failure check if fopen fails in the constructor?
No option to skip the locking call?
Why not use streams here, the Streams API have alot more functions built in (I know internally fopen uses streams)
Theres no check for if an file handle is valid or not:
In the DingoLoad::view() method, the extract() call should be after the foreach, else it may overwrite $this (I know its not very likely), plus it might also overwrite $view.
In the DingoInput class, you should use isset, instead of @. You may also find this article by Derick interesting:
Other lookings at the framework, I feel that the following topics lacks abit:
Error handling, you should use an error/exception handler and make it possible to show non fatal errors in a view for example, or automaticlly creation of an error view if for example a controller threw "throw new RuntimeException('blah blah blah');" (RuntimeException in this case from SPL)
Database access layer, the current is not even a layer so its hard to deal with multiple database types within the same API
Thats it for now ;)
View Public Profile
Send a private message to Kalle
Visit Kalle's homepage!
Find More Posts by Kalle