01-17-2009, 08:03 PM
|
#60 (permalink)
|
|
Moderateur
Join Date: Apr 2007
Posts: 1,377
Thanks: 5
|
Tanax: I don't know if you noticed but I made a whole bunch of comments on your previous version, revision 55.
It's ok there's nothing too huge to worry about, I guess the main is that magic quotes line in the secure method. Also, there's the overall comment (which I'll quote to save you clicking) which could do with some attention.
Quote:
Why are there so many places where one can provide a SQL query as an argument? I count 5.
There also appears to be a confusing selection of ways to achieve a usually simple task: grab an assoc. array of results. More clear documentation of the use of this class is requested (perhaps on the forums).
|
|
|
|
|