01-16-2009, 05:10 AM
|
#25 (permalink)
|
|
The Prestige
Join Date: Dec 2007
Posts: 1,044
Thanks: 193
|
Quote:
Originally Posted by Village Idiot
Much better, but still a few small things: - What is the purpose of &option?
- Make name2id name_to_id. But why is the function necessary? Isn't the ID of the setting part of the returned array?
- Why assign the parameters to the private variables then use them?
I think we had slightly different ideas on how to structure this (I did not make myself clear on this matter). I am not looking for any data to stay in the class past the function. The private variables are not necessary.
When these revisions are made, stick the code in the SVN repository and we can begin talking about the additions I want made to it. |
I can get rid of the option since it pretty much has no function now except edit() which was using name2id for the option_id, maybe I could just make it where you can edit it by the id and just add the other two parameters and get rid of option() ?
__________________
VillageIdiot can have my babbies ;d
|
|
|
|