01-16-2009, 05:05 AM
|
#24 (permalink)
|
|
Wizard
Join Date: Sep 2007
Posts: 1,299
Thanks: 17
|
Much better, but still a few small things: - What is the purpose of &option?
- Make name2id name_to_id. But why is the function necessary? Isn't the ID of the setting part of the returned array?
- Why assign the parameters to the private variables then use them?
I think we had slightly different ideas on how to structure this (I did not make myself clear on this matter). I am not looking for any data to stay in the class past the function. The private variables are not necessary.
When these revisions are made, stick the code in the SVN repository and we can begin talking about the additions I want made to it.
|
|
|
|