The Config Class
View Single Post
01-16-2009, 04:56 AM
Join Date: Dec 2007
Originally Posted by
Good work, but there is quite a bit that needs to be fixed. Here is what I want done (all small things):
Are so many comments really required (especially towards the beginning)? You heavily comment the declarations (which honestly is not necessary) yet leave out comments on the actual processing code.
Don't trigger errors when the script can still continue. Some procedure had changed and we are no longer going by exceptions, just return something to indicate failure.
Those constants are really not necessary.
Why are you assigning $this->query then using it once? Wouldn't it make more sense just to directly run the query?
Use parameters for the creation, dont make the programmer assign two class variables than run it.
This is a general database programming rule, always always always go by unique ID when possible. Make delete() delete by an ID given in a parameter.
Done. (chars) check op
"The reasonable man adapts himself to the conditions that surround him... The unreasonable man adapts surrounding conditions to himself... All progress depends on the unreasonable man." - George Bernard Shaw
View Public Profile
Send a private message to Orc
Visit Orc's homepage!
Find More Posts by Orc