TalkPHP - View Single Post

Kalle · 11-18-2008, 12:09 AM

Just as a note your class requires PHP 5.2.5 because it uses all the imagefilter() constants and do not check if their availability for people who may use this for cross php version scripts.

Another thing I've noticed, wouldn't it be easier to make a new exception instead of prefixing all error messages sent to the Exception class. Eg.:

PHP Code:


			
class ImageException extends Exception

{

    public function __construct($message)

    {

        parent::__construct('[Image error] ' . $message);

    }

}

11-18-2008, 12:09 AM	#7 (permalink)
Kalle The Frequenter Join Date: Sep 2007 Location: Denmark Posts: 352 Thanks: 8	Just as a note your class requires PHP 5.2.5 because it uses all the imagefilter() constants and do not check if their availability for people who may use this for cross php version scripts. Another thing I've noticed, wouldn't it be easier to make a new exception instead of prefixing all error messages sent to the Exception class. Eg.: PHP Code: `class ImageException extends Exception { public function __construct($message) { parent::__construct('[Image error] ' . $message); } }` __________________