View Single Post
Old 08-25-2008, 05:00 AM   #5 (permalink)
dschreck
The Contributor
 
dschreck's Avatar
 
Join Date: Nov 2007
Location: California
Posts: 82
Thanks: 0
dschreck is on a distinguished road
Default

I've stopped relying upon getmxrr(), there are various reasons why, but what it comes down to is it's not reliable.

If you want to make sure the user has a working e-mail address just send a verification e-mail + activation code.


Also be aware that $_SERVER['HTTP_USER_AGENT']; can change while a user is logged in with some browsers.


You also switch between using boolean values, and doing if conditions and checking for 1 for true.
I'd recommend just using one convention, and maybe even using '===' to check your value and type.



Also, your functions only return strings if there's an error, if you ask me, that's what the $errormessge[] array is for.

Inside of classes you should return a true or false, and then retrieving your output from another getter.

Hope that helps a little.
__________________
Where I Ramble: http://www.iwilldomybest.com/
What I do: Zynga Game Network
Senior Software Engineer at CityVille
dschreck is offline  
Reply With Quote