Thread: TalkPHP Project
View Single Post
Old 06-22-2008, 03:08 AM   #85 (permalink)
Village Idiot
Wizard
Top Contributor 
 
Village Idiot's Avatar
 
Join Date: Sep 2007
Posts: 1,299
Thanks: 17
Village Idiot is on a distinguished road
Default

My thoughts on the proposed standards:

1. Indentations
The problem with different tab spacing can be solved by having tabs set to five spaces. Most IDEs can do this.

2. String concatenation
Why no space? It makes the code cleaner looking to do so. I would recommend having a space before and after the period.

3. Single line if statements
It is not a good idea to allow single line if statements at all because it is always possible a second line will be needed. A programmer could easily accidental add a line with no brackets. Then boom, you have a bug on your hand. Even if it does not take a long time to resolve, it is still a good idea to use brackets.

4. Comparison operators
This is PHP, not basic. Use the C++ style operators (&& and ||) in if statements.

5. Ternaries
Ternary operators are harder to read and edit than normal if statements and should probably be disallowed completely.

Concepts
CMS -Probably too large to make and too heavy to maintain since we have a small volunteer force. And not to be politically incorrect, most of the force won't be competent enough to pull this off.
Framework -Too many out there.
Text Based Game -The purpose of this project is to give an open source script people can use. Doesn't it seem like a dumb idea to give everyone the same game they can host? It would be pretty much useless and we probably wouldn't have many takers. Plus, a game would be really heavy on the server so anyone who uses it would have to decent server. I don't think we would even want to put it on our box.
__________________

Village Idiot is offline  
Reply With Quote