Eyes Random String Generator
View Single Post
06-11-2008, 10:31 AM
Join Date: Apr 2007
I would advise making the function somewhat more efficient. There are a number of things which, unless you can justify their inclusion or the way they've been done, I feel are useless or could be better implemented.
First, the method of constructing the array of characters which can be used in the generated string. You make four function calls (range, array_merge) simply to construct a single array of characters
. This array will always be the same upon every function call so why not just hard-code?
lines. What advantage does shuffling the array 5, 10, 50 times have over doing it once? Does it make the array
random? I'd say this whole section is unnecessary since you're later choosing array keys at random anyway (with
I'd also suggest returning the resulting string rather than echoing out each character as the function will be much more versatile (who says you need to output the string?).
Sketch, thanks for the note about the off-by-one error on
however you introduce one yourself by changing the final for loop to use
(the resulting random string will always be one character less than
I think this function could well be refactored into something maybe 10 times faster to run and equally so easy to glance at and understand what's going on.
The Following User Says Thank You to Salathe For This Useful Post:
View Public Profile
Send a private message to Salathe
Visit Salathe's homepage!
Find More Posts by Salathe